For #26867 - Remove feature flag for first run onboarding updates

app/src/main/java/org/mozilla/fenix/utils/Settings.kt

@@ -1255,15 +1255,6 @@ class Settings(private val appContext: Context) : PreferencesHolder {
         default = { mr2022Sections[Mr2022Section.HOME_ONBOARDING_DIALOG_EXISTING_USERS] == true },
     )
 
-    /**
-     * Indicates if home onboarding dialog should be shown.
-     */
-    var showFirstRunOnboardingUpdate by lazyFeatureFlagPreference(
-        appContext.getPreferenceKey(R.string.pref_key_show_first_run_onboarding_update),
-        featureFlag = FeatureFlags.showFirstRunOnboardingUpdates,
-        default = { mr2022Sections[Mr2022Section.HOME_ONBOARDING_DIALOG_NEW_USERS] == true },
-    )
-
     /**
      * Indicates if the recent tabs functionality should be visible.
      * Returns true if the [FeatureFlags.showRecentTabsFeature] and [R.string.pref_key_recent_tabs] are true.

app/src/main/res/values/preference_keys.xml

@@ -243,8 +243,6 @@
     <string name="pref_key_should_show_sync_cfr" translatable="false">pref_key_should_show_sync_cfr</string>
     <!-- A value  of `true` means the home onboarding dialog have not been shown yet -->
     <string name="pref_key_should_show_home_onboarding_dialog" translatable="false">pref_key_should_show_home_onboarding_dialog</string>
-    <!-- A value  of `true` means the first run onboarding updates should be shown -->
-    <string name="pref_key_show_first_run_onboarding_update" translatable="false">pref_key_show_first_run_onboarding_update</string>
     <!-- A value  of `true` means the total cookie protection popup has not been shown yet -->
     <string name="pref_key_should_show_total_cookie_protection_popup" translatable="false">pref_key_should_show_total_cookie_protection_popup</string>
 

nimbus.fml.yaml

@@ -189,7 +189,6 @@ features:
         type: Map<MR2022Section, Boolean>
         default:
           {
-            "home-onboarding-dialog-new-users": false,
             "home-onboarding-dialog-existing-users": false,
             "sync-cfr": false,
             "wallpapers-selection-tool": false,
@@ -201,7 +200,6 @@ features:
       - channel: developer
         value: {
           "sections-enabled": {
-            "home-onboarding-dialog-new-users": true,
             "home-onboarding-dialog-existing-users": true,
             "sync-cfr": true,
             "wallpapers-selection-tool": true,
@@ -337,8 +335,6 @@ types:
       variants:
         home-onboarding-dialog-existing-users:
           description: Home onboarding dialog for upgraded users.
-        home-onboarding-dialog-new-users:
-          description: Home onboarding dialog for new users.
         sync-cfr:
           description: CFR for the first time you see a synced tab on the home screen.
         wallpapers-selection-tool: