From b5f9134e62d3f3796e933a04123874a3ddf2c047 Mon Sep 17 00:00:00 2001 From: DreVla Date: Tue, 15 Nov 2022 15:26:41 +0200 Subject: [PATCH] [fenix] For https://github.com/mozilla-mobile/fenix/issues/27801 - Update header text for the search selector menu --- .../org/mozilla/fenix/search/toolbar/SearchSelectorMenu.kt | 2 +- app/src/main/res/values/strings.xml | 4 +++- .../mozilla/fenix/search/toolbar/SearchSelectorMenuTest.kt | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/org/mozilla/fenix/search/toolbar/SearchSelectorMenu.kt b/app/src/main/java/org/mozilla/fenix/search/toolbar/SearchSelectorMenu.kt index 88eb7d3a20..205eaf7c9a 100644 --- a/app/src/main/java/org/mozilla/fenix/search/toolbar/SearchSelectorMenu.kt +++ b/app/src/main/java/org/mozilla/fenix/search/toolbar/SearchSelectorMenu.kt @@ -50,7 +50,7 @@ class SearchSelectorMenu( internal fun menuItems(searchEngines: List): List { val headerCandidate = DecorativeTextMenuCandidate( - text = context.getString(R.string.search_header_menu_item), + text = context.getString(R.string.search_header_menu_item_2), ) val settingsCandidate = TextMenuCandidate( text = context.getString(R.string.search_settings_menu_item), diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 8dfc370711..aa80d0dcc2 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -244,7 +244,9 @@ Search settings - This time search: + This time search: + + This time search in: diff --git a/app/src/test/java/org/mozilla/fenix/search/toolbar/SearchSelectorMenuTest.kt b/app/src/test/java/org/mozilla/fenix/search/toolbar/SearchSelectorMenuTest.kt index 38c49564d6..7dafa65458 100644 --- a/app/src/test/java/org/mozilla/fenix/search/toolbar/SearchSelectorMenuTest.kt +++ b/app/src/test/java/org/mozilla/fenix/search/toolbar/SearchSelectorMenuTest.kt @@ -35,7 +35,7 @@ class SearchSelectorMenuTest { lastItem.onClick() assertEquals( - testContext.getString(R.string.search_header_menu_item), + testContext.getString(R.string.search_header_menu_item_2), (items.first() as DecorativeTextMenuCandidate).text, ) assertEquals(