For #22784: Show collection snackbar only if fragment is still attached.

upstream-sync
mcarare 3 years ago committed by mergify[bot]
parent 0cb4059b12
commit b4bf7abfb3

@ -42,6 +42,7 @@ import org.mozilla.fenix.databinding.TabstrayMultiselectItemsBinding
import org.mozilla.fenix.ext.components import org.mozilla.fenix.ext.components
import org.mozilla.fenix.ext.metrics import org.mozilla.fenix.ext.metrics
import org.mozilla.fenix.ext.requireComponents import org.mozilla.fenix.ext.requireComponents
import org.mozilla.fenix.ext.runIfFragmentIsAttached
import org.mozilla.fenix.ext.settings import org.mozilla.fenix.ext.settings
import org.mozilla.fenix.home.HomeScreenViewModel import org.mozilla.fenix.home.HomeScreenViewModel
import org.mozilla.fenix.share.ShareFragment import org.mozilla.fenix.share.ShareFragment
@ -485,6 +486,7 @@ class TabsTrayFragment : AppCompatDialogFragment() {
isNewCollection: Boolean = false, isNewCollection: Boolean = false,
collectionToSelect: Long? collectionToSelect: Long?
) { ) {
runIfFragmentIsAttached {
FenixSnackbar FenixSnackbar
.make(requireView()) .make(requireView())
.collectionMessage(tabSize, isNewCollection) .collectionMessage(tabSize, isNewCollection)
@ -498,6 +500,7 @@ class TabsTrayFragment : AppCompatDialogFragment() {
dismissTabsTray() dismissTabsTray()
}.show() }.show()
} }
}
@VisibleForTesting @VisibleForTesting
internal fun showBookmarkSnackbar( internal fun showBookmarkSnackbar(

Loading…
Cancel
Save