Archives/iceraven-browser
2
0
Fork 0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-05 21:20:45 +00:00
Code Issues Releases Wiki Activity

[fenix] For https://github.com/mozilla-mobile/fenix/issues/25810 - Unified search should give hint to user that there are more menu items available by scrolling (https://github.com/mozilla-mobile/fenix/pull/27895)

Browse Source 
* For https://github.com/mozilla-mobile/fenix/issues/25810 - Unified search should give hint to user that there are more menu items available by scrolling

* For https://github.com/mozilla-mobile/fenix/issues/25810: Updated AC version

Co-authored-by: t-p-white <t-p-white>
This commit is contained in:
t-p-white 2023-01-09 17:13:04 +00:00 committed by GitHub
parent 516eb62a76
commit b2bfae66da
4 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt
View File

@ -361,7 +361,7 @@ class HomeFragment : Fragment() {
}
UnifiedSearch.searchMenuTapped.record(NoExtras())
searchSelectorMenu.menuController.show(anchor = it, orientation = orientation, forceOrientation = true)
searchSelectorMenu.menuController.show(anchor = it, orientation = orientation)
}
}

2
app/src/main/java/org/mozilla/fenix/search/toolbar/SearchSelectorToolbarAction.kt
View File

@ -63,7 +63,7 @@ class SearchSelectorToolbarAction(
}
UnifiedSearch.searchMenuTapped.record(NoExtras())
menu.menuController.show(anchor = it, orientation = orientation, forceOrientation = true)
menu.menuController.show(anchor = it, orientation = orientation)
}
val topPadding = resources.getDimensionPixelSize(R.dimen.search_engine_engine_icon_top_margin)

4
app/src/test/java/org/mozilla/fenix/search/toolbar/SearchSelectorToolbarActionTest.kt
View File

@ -87,7 +87,7 @@ class SearchSelectorToolbarActionTest {
assertNotNull(UnifiedSearch.searchMenuTapped.testGetValue())
verify {
menu.menuController.show(view, Orientation.DOWN, true)
menu.menuController.show(view, Orientation.DOWN)
}
every { settings.shouldUseBottomToolbar } returns true
@ -95,7 +95,7 @@ class SearchSelectorToolbarActionTest {
assertNotNull(UnifiedSearch.searchMenuTapped.testGetValue())
verify {
menu.menuController.show(view, Orientation.UP, true)
menu.menuController.show(view, Orientation.UP)
}
}

2
buildSrc/src/main/java/AndroidComponents.kt
View File

@ -3,5 +3,5 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
object AndroidComponents {
const val VERSION = "110.0.20230108143241"
const val VERSION = "110.0.20230109143319"
}