Archives/iceraven-browser
2
0
Fork 0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-11 13:11:01 +00:00
Code Issues Releases Wiki Activity

For #25110: Enable the messaging framework feature

Browse Source
This commit is contained in:
Arturo Mejia 2022-05-05 08:39:39 -04:00
parent 3e9dbaca35
commit b22a34db2e
3 changed files with 9 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/src/main/java/org/mozilla/fenix/FeatureFlags.kt
View File

@ -95,5 +95,5 @@ object FeatureFlags {
/** /**
* Enables receiving from the messaging framework. * Enables receiving from the messaging framework.
*/ */
val messagingFeature = Config.channel.isNightlyOrDebug const val messagingFeature = true
} }

10
app/src/test/java/org/mozilla/fenix/gleanplumb/MessagingFeatureTest.kt
View File

@ -4,17 +4,12 @@
package org.mozilla.fenix.gleanplumb package org.mozilla.fenix.gleanplumb
import io.mockk.every
import io.mockk.mockkObject
import io.mockk.spyk import io.mockk.spyk
import io.mockk.unmockkObject
import io.mockk.verify import io.mockk.verify
import kotlinx.coroutines.ExperimentalCoroutinesApi import kotlinx.coroutines.ExperimentalCoroutinesApi
import mozilla.components.support.test.rule.MainCoroutineRule import mozilla.components.support.test.rule.MainCoroutineRule
import org.junit.Rule import org.junit.Rule
import org.junit.Test import org.junit.Test
import org.mozilla.fenix.Config
import org.mozilla.fenix.FeatureFlags
import org.mozilla.fenix.components.AppStore import org.mozilla.fenix.components.AppStore
import org.mozilla.fenix.components.appstate.AppAction.MessagingAction import org.mozilla.fenix.components.appstate.AppAction.MessagingAction
@ -28,13 +23,8 @@ class MessagingFeatureTest {
val store: AppStore = spyk(AppStore()) val store: AppStore = spyk(AppStore())
val binding = MessagingFeature(store) val binding = MessagingFeature(store)
mockkObject(FeatureFlags)
every { FeatureFlags.messagingFeature } returns true
binding.start() binding.start()
verify { store.dispatch(MessagingAction.Evaluate) } verify { store.dispatch(MessagingAction.Evaluate) }
unmockkObject(Config)
} }
} }

17
nimbus.fml.yaml
View File

@ -160,6 +160,13 @@ features:
URGENT: URGENT:
priority: 100 priority: 100
max-display-count: 10 max-display-count: 10
messages:
default-browser:
text: default_browser_experiment_card_text
action: "MAKE_DEFAULT_BROWSER"
trigger: [ "I_AM_NOT_DEFAULT_BROWSER" ]
style: "DEFAULT"
button-label: preferences_set_as_default_browser
- channel: developer - channel: developer
value: value:
@ -170,15 +177,7 @@ features:
EXPIRES_QUICKLY: EXPIRES_QUICKLY:
priority: 100 priority: 100
max-display-count: 1 max-display-count: 1
- channel: nightly
value:
messages:
default-browser:
text: default_browser_experiment_card_text
action: "MAKE_DEFAULT_BROWSER"
trigger: [ "I_AM_NOT_DEFAULT_BROWSER" ]
style: "DEFAULT"
button-label: preferences_set_as_default_browser
unified-search: unified-search:
description: A feature allowing user to easily search for specified results directly in the search bar. description: A feature allowing user to easily search for specified results directly in the search bar.
variables: variables: