From b15c3ff864b42776d1d9ce134c2914c50b4a29d3 Mon Sep 17 00:00:00 2001 From: Elise Richards Date: Fri, 12 Mar 2021 12:13:53 -0600 Subject: [PATCH] Add open in app to main three dot menu (#18462) --- .../fenix/components/toolbar/DefaultToolbarMenu.kt | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/app/src/main/java/org/mozilla/fenix/components/toolbar/DefaultToolbarMenu.kt b/app/src/main/java/org/mozilla/fenix/components/toolbar/DefaultToolbarMenu.kt index 1bcbd24941..38ac495d29 100644 --- a/app/src/main/java/org/mozilla/fenix/components/toolbar/DefaultToolbarMenu.kt +++ b/app/src/main/java/org/mozilla/fenix/components/toolbar/DefaultToolbarMenu.kt @@ -441,6 +441,19 @@ class DefaultToolbarMenu( onItemTapped.invoke(ToolbarMenu.Item.CustomizeReaderView) } + val openInApp = BrowserMenuHighlightableItem( + label = context.getString(R.string.browser_menu_open_app_link), + startImageResource = R.drawable.ic_open_in_app, + iconTintColorResource = primaryTextColor(), + highlight = BrowserMenuHighlight.LowPriority( + label = context.getString(R.string.browser_menu_open_app_link), + notificationTint = getColor(context, R.color.whats_new_notification_color) + ), + isHighlighted = { !context.settings().openInAppOpened } + ) { + onItemTapped.invoke(ToolbarMenu.Item.OpenInApp) + } + val reportSiteIssuePlaceholder = WebExtensionPlaceholderMenuItem( id = WebCompatReporterFeature.WEBCOMPAT_REPORTER_EXTENSION_ID ) @@ -500,6 +513,7 @@ class DefaultToolbarMenu( findInPageItem, desktopSiteItem, customizeReaderView.apply { visible = ::shouldShowReaderViewCustomization }, + openInApp.apply { visible = ::shouldShowOpenInApp }, reportSiteIssuePlaceholder, BrowserMenuDivider(), addToHomeScreenItem.apply { visible = ::canAddToHomescreen },