From b057c4453cfa5c619fed9309aa0d33406d500e70 Mon Sep 17 00:00:00 2001
From: mcarare <mihai.carare.dev@gmail.com>
Date: Wed, 5 Oct 2022 13:12:27 +0300
Subject: [PATCH] [fenix] For
 https://github.com/mozilla-mobile/fenix/issues/27253: Add content description
 to close button.

---
 .../main/java/org/mozilla/fenix/onboarding/view/Onboarding.kt   | 2 +-
 app/src/main/res/values/strings.xml                             | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/app/src/main/java/org/mozilla/fenix/onboarding/view/Onboarding.kt b/app/src/main/java/org/mozilla/fenix/onboarding/view/Onboarding.kt
index 1000058043..61dd88e84c 100644
--- a/app/src/main/java/org/mozilla/fenix/onboarding/view/Onboarding.kt
+++ b/app/src/main/java/org/mozilla/fenix/onboarding/view/Onboarding.kt
@@ -96,7 +96,7 @@ fun Onboarding(
             ) {
                 Icon(
                     painter = painterResource(id = R.drawable.mozac_ic_close),
-                    contentDescription = null,
+                    contentDescription = stringResource(R.string.onboarding_home_content_description_close_button),
                     tint = FirefoxTheme.colors.iconPrimary,
                 )
             }
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 47af11c7bf..fffe785ad9 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -287,6 +287,8 @@
     <string name="onboarding_home_skip_button">Skip</string>
     <!-- Onboarding home screen sync popup dialog message, shown on top of Recent Synced Tabs in the Jump back in section. -->
     <string name="sync_cfr_message">Your tabs are syncing! Pick up where you left off on your other device.</string>
+    <!-- Content description (not visible, for screen readers etc.): Close button for the home onboarding dialog -->
+    <string name="onboarding_home_content_description_close_button">Close</string>
 
     <!-- Search Widget -->
     <!-- Content description for searching with a widget. The first parameter is the name of the application.-->