[fenix] For https://github.com/mozilla-mobile/fenix/issues/2260 - Sends valid keys to the labeled counter (https://github.com/mozilla-mobile/fenix/pull/2330)

app/metrics.yaml

@@ -57,10 +57,10 @@ events:
       source:
         description: >
           A string that tells us how the user performed the search. Possible values are:
-          * default.action
-          * default.suggestion
-          * shortcut.action
-          * shortcut.suggestion
+          * default_action
+          * default_suggestion
+          * shortcut_action
+          * shortcut_suggestion
 
     bugs:
     - 959
@@ -328,7 +328,7 @@ metrics:
   search_count:
     type: labeled_counter
     description: >
-      The labels for this counter are `<search-engine-name>.<source>`.
+      The labels for this counter are `<search-engine-name>_<source>`.
 
       If the search engine is bundled with Fenix `search-engine-name` will be the name of the search engine. If it's a
       custom search engine (defined: https://github.com/mozilla-mobile/fenix/issues/1607) the value will be `custom`.

app/src/main/java/org/mozilla/fenix/components/metrics/Metrics.kt

@@ -145,10 +145,10 @@ sealed class Event {
                 }
 
             val countLabel: String
-                get() = "${source.searchEngine.identifier}.$label"
+                get() = "${source.searchEngine.name.toLowerCase()}_$label"
 
             val sourceLabel: String
-                get() = "${source.descriptor}.$label"
+                get() = "${source.descriptor}_$label"
         }
 
         override val extras: Map<String, String>?