Archives/iceraven-browser
2
0
Fork 0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-03 23:15:31 +00:00
Code Issues Releases Wiki Activity

For #19746 - Remove FeatureFlags.nimbusExperiments (#19771)

Browse Source
This commit is contained in:
Gabriel Luong 2021-06-03 11:35:05 -04:00 committed by GitHub
parent e4fa71fde7
commit a5110f8c0a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
app/src/main/java/org/mozilla/fenix/FeatureFlags.kt
View File

@ -14,11 +14,6 @@ object FeatureFlags {
*/
val pullToRefreshEnabled = Config.channel.isNightlyOrDebug
/**
* Enables the Nimbus experiments library.
*/
const val nimbusExperiments = true
/**
* Enables the Addresses autofill feature.
*/

15
app/src/main/java/org/mozilla/fenix/components/Analytics.kt
View File

@ -14,10 +14,8 @@ import mozilla.components.lib.crash.service.GleanCrashReporterService
import mozilla.components.lib.crash.service.MozillaSocorroService
import mozilla.components.lib.crash.service.SentryService
import mozilla.components.service.nimbus.NimbusApi
import mozilla.components.service.nimbus.NimbusDisabled
import org.mozilla.fenix.BuildConfig
import org.mozilla.fenix.Config
import org.mozilla.fenix.FeatureFlags
import org.mozilla.fenix.HomeActivity
import org.mozilla.fenix.R
import org.mozilla.fenix.ReleaseChannel
@ -25,7 +23,6 @@ import org.mozilla.fenix.components.metrics.AdjustMetricsService
import org.mozilla.fenix.components.metrics.GleanMetricsService
import org.mozilla.fenix.components.metrics.MetricController
import org.mozilla.fenix.experiments.createNimbus
import org.mozilla.fenix.ext.components
import org.mozilla.fenix.ext.settings
import org.mozilla.fenix.perf.lazyMonitored
import org.mozilla.fenix.utils.Mockable
@ -59,9 +56,11 @@ class Analytics(
// The name "Fenix" here matches the product name on Socorro and is unrelated to the actual app name:
// https://bugzilla.mozilla.org/show_bug.cgi?id=1523284
val socorroService = MozillaSocorroService(context, appName = "Fenix",
val socorroService = MozillaSocorroService(
context, appName = "Fenix",
version = MOZ_APP_VERSION, buildId = MOZ_APP_BUILDID, vendor = MOZ_APP_VENDOR,
releaseChannel = MOZ_UPDATE_CHANNEL)
releaseChannel = MOZ_UPDATE_CHANNEL
)
services.add(socorroService)
val intent = Intent(context, HomeActivity::class.java).apply {
@ -102,11 +101,7 @@ class Analytics(
}
val experiments: NimbusApi by lazyMonitored {
if (FeatureFlags.nimbusExperiments) {
createNimbus(context, BuildConfig.NIMBUS_ENDPOINT)
} else {
NimbusDisabled()
}
createNimbus(context, BuildConfig.NIMBUS_ENDPOINT)
}
}

2
app/src/main/java/org/mozilla/fenix/settings/DataChoicesFragment.kt
View File

@ -7,7 +7,6 @@ package org.mozilla.fenix.settings
import android.os.Bundle
import androidx.preference.PreferenceFragmentCompat
import androidx.preference.SwitchPreference
import org.mozilla.fenix.FeatureFlags
import org.mozilla.fenix.R
import org.mozilla.fenix.components.metrics.MetricServiceType
import org.mozilla.fenix.ext.components
@ -72,7 +71,6 @@ class DataChoicesFragment : PreferenceFragmentCompat() {
requirePreference<SwitchPreference>(R.string.pref_key_experimentation).apply {
isChecked = context.settings().isExperimentationEnabled
isVisible = FeatureFlags.nimbusExperiments
onPreferenceChangeListener = SharedPreferenceUpdater()
}
}