mirror of
https://github.com/fork-maintainers/iceraven-browser
synced 2024-11-11 13:11:01 +00:00
Co-authored-by: codrut.topliceanu <codrut.topliceanu@softvision.ro> Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
This commit is contained in:
parent
0b764fd3e4
commit
a3d401a3b7
@ -3415,6 +3415,19 @@ top_sites:
|
|||||||
notification_emails:
|
notification_emails:
|
||||||
- fenix-core@mozilla.com
|
- fenix-core@mozilla.com
|
||||||
expires: "2021-08-01"
|
expires: "2021-08-01"
|
||||||
|
open_google_search_attribution:
|
||||||
|
type: event
|
||||||
|
description: |
|
||||||
|
A user opened the google top site
|
||||||
|
bugs:
|
||||||
|
- https://github.com/mozilla-mobile/fenix/issues/17418
|
||||||
|
data_reviews:
|
||||||
|
- https://github.com/mozilla-mobile/fenix/pull/17637
|
||||||
|
data_sensitivity:
|
||||||
|
- interaction
|
||||||
|
notification_emails:
|
||||||
|
- fenix-core@mozilla.com
|
||||||
|
expires: "2021-08-01"
|
||||||
open_frecency:
|
open_frecency:
|
||||||
type: event
|
type: event
|
||||||
description: |
|
description: |
|
||||||
|
@ -122,6 +122,7 @@ sealed class Event {
|
|||||||
object NotificationMediaPlay : Event()
|
object NotificationMediaPlay : Event()
|
||||||
object NotificationMediaPause : Event()
|
object NotificationMediaPause : Event()
|
||||||
object TopSiteOpenDefault : Event()
|
object TopSiteOpenDefault : Event()
|
||||||
|
object TopSiteOpenGoogle : Event()
|
||||||
object TopSiteOpenFrecent : Event()
|
object TopSiteOpenFrecent : Event()
|
||||||
object TopSiteOpenPinned : Event()
|
object TopSiteOpenPinned : Event()
|
||||||
object TopSiteOpenInNewTab : Event()
|
object TopSiteOpenInNewTab : Event()
|
||||||
|
@ -516,6 +516,9 @@ private val Event.wrapper: EventWrapper<*>?
|
|||||||
is Event.TopSiteOpenDefault -> EventWrapper<NoExtraKeys>(
|
is Event.TopSiteOpenDefault -> EventWrapper<NoExtraKeys>(
|
||||||
{ TopSites.openDefault.record(it) }
|
{ TopSites.openDefault.record(it) }
|
||||||
)
|
)
|
||||||
|
is Event.TopSiteOpenGoogle -> EventWrapper<NoExtraKeys>(
|
||||||
|
{ TopSites.openGoogleSearchAttribution.record(it) }
|
||||||
|
)
|
||||||
is Event.TopSiteOpenFrecent -> EventWrapper<NoExtraKeys>(
|
is Event.TopSiteOpenFrecent -> EventWrapper<NoExtraKeys>(
|
||||||
{ TopSites.openFrecency.record(it) }
|
{ TopSites.openFrecency.record(it) }
|
||||||
)
|
)
|
||||||
|
@ -372,6 +372,10 @@ class DefaultSessionControlController(
|
|||||||
TopSite.Type.PINNED -> metrics.track(Event.TopSiteOpenPinned)
|
TopSite.Type.PINNED -> metrics.track(Event.TopSiteOpenPinned)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if (url == SupportUtils.GOOGLE_URL) {
|
||||||
|
metrics.track(Event.TopSiteOpenGoogle)
|
||||||
|
}
|
||||||
|
|
||||||
if (url == SupportUtils.POCKET_TRENDING_URL) {
|
if (url == SupportUtils.POCKET_TRENDING_URL) {
|
||||||
metrics.track(Event.PocketTopSiteClicked)
|
metrics.track(Event.PocketTopSiteClicked)
|
||||||
}
|
}
|
||||||
|
@ -369,6 +369,7 @@ class DefaultSessionControlControllerTest {
|
|||||||
controller.handleSelectTopSite(topSiteUrl, TopSite.Type.DEFAULT)
|
controller.handleSelectTopSite(topSiteUrl, TopSite.Type.DEFAULT)
|
||||||
verify { metrics.track(Event.TopSiteOpenInNewTab) }
|
verify { metrics.track(Event.TopSiteOpenInNewTab) }
|
||||||
verify { metrics.track(Event.TopSiteOpenDefault) }
|
verify { metrics.track(Event.TopSiteOpenDefault) }
|
||||||
|
verify { metrics.track(Event.TopSiteOpenGoogle) }
|
||||||
verify {
|
verify {
|
||||||
tabsUseCases.addTab.invoke(
|
tabsUseCases.addTab.invoke(
|
||||||
url = SupportUtils.GOOGLE_US_URL,
|
url = SupportUtils.GOOGLE_US_URL,
|
||||||
@ -388,6 +389,7 @@ class DefaultSessionControlControllerTest {
|
|||||||
controller.handleSelectTopSite(topSiteUrl, TopSite.Type.DEFAULT)
|
controller.handleSelectTopSite(topSiteUrl, TopSite.Type.DEFAULT)
|
||||||
verify { metrics.track(Event.TopSiteOpenInNewTab) }
|
verify { metrics.track(Event.TopSiteOpenInNewTab) }
|
||||||
verify { metrics.track(Event.TopSiteOpenDefault) }
|
verify { metrics.track(Event.TopSiteOpenDefault) }
|
||||||
|
verify { metrics.track(Event.TopSiteOpenGoogle) }
|
||||||
verify {
|
verify {
|
||||||
tabsUseCases.addTab.invoke(
|
tabsUseCases.addTab.invoke(
|
||||||
SupportUtils.GOOGLE_XX_URL,
|
SupportUtils.GOOGLE_XX_URL,
|
||||||
@ -407,6 +409,7 @@ class DefaultSessionControlControllerTest {
|
|||||||
controller.handleSelectTopSite(topSiteUrl, TopSite.Type.PINNED)
|
controller.handleSelectTopSite(topSiteUrl, TopSite.Type.PINNED)
|
||||||
verify { metrics.track(Event.TopSiteOpenInNewTab) }
|
verify { metrics.track(Event.TopSiteOpenInNewTab) }
|
||||||
verify { metrics.track(Event.TopSiteOpenPinned) }
|
verify { metrics.track(Event.TopSiteOpenPinned) }
|
||||||
|
verify { metrics.track(Event.TopSiteOpenGoogle) }
|
||||||
verify {
|
verify {
|
||||||
tabsUseCases.addTab.invoke(
|
tabsUseCases.addTab.invoke(
|
||||||
SupportUtils.GOOGLE_US_URL,
|
SupportUtils.GOOGLE_US_URL,
|
||||||
@ -426,6 +429,7 @@ class DefaultSessionControlControllerTest {
|
|||||||
controller.handleSelectTopSite(topSiteUrl, TopSite.Type.PINNED)
|
controller.handleSelectTopSite(topSiteUrl, TopSite.Type.PINNED)
|
||||||
verify { metrics.track(Event.TopSiteOpenInNewTab) }
|
verify { metrics.track(Event.TopSiteOpenInNewTab) }
|
||||||
verify { metrics.track(Event.TopSiteOpenPinned) }
|
verify { metrics.track(Event.TopSiteOpenPinned) }
|
||||||
|
verify { metrics.track(Event.TopSiteOpenGoogle) }
|
||||||
verify {
|
verify {
|
||||||
tabsUseCases.addTab.invoke(
|
tabsUseCases.addTab.invoke(
|
||||||
SupportUtils.GOOGLE_XX_URL,
|
SupportUtils.GOOGLE_XX_URL,
|
||||||
@ -445,6 +449,7 @@ class DefaultSessionControlControllerTest {
|
|||||||
controller.handleSelectTopSite(topSiteUrl, TopSite.Type.FRECENT)
|
controller.handleSelectTopSite(topSiteUrl, TopSite.Type.FRECENT)
|
||||||
verify { metrics.track(Event.TopSiteOpenInNewTab) }
|
verify { metrics.track(Event.TopSiteOpenInNewTab) }
|
||||||
verify { metrics.track(Event.TopSiteOpenFrecent) }
|
verify { metrics.track(Event.TopSiteOpenFrecent) }
|
||||||
|
verify { metrics.track(Event.TopSiteOpenGoogle) }
|
||||||
verify {
|
verify {
|
||||||
tabsUseCases.addTab.invoke(
|
tabsUseCases.addTab.invoke(
|
||||||
SupportUtils.GOOGLE_US_URL,
|
SupportUtils.GOOGLE_US_URL,
|
||||||
@ -464,6 +469,7 @@ class DefaultSessionControlControllerTest {
|
|||||||
controller.handleSelectTopSite(topSiteUrl, TopSite.Type.FRECENT)
|
controller.handleSelectTopSite(topSiteUrl, TopSite.Type.FRECENT)
|
||||||
verify { metrics.track(Event.TopSiteOpenInNewTab) }
|
verify { metrics.track(Event.TopSiteOpenInNewTab) }
|
||||||
verify { metrics.track(Event.TopSiteOpenFrecent) }
|
verify { metrics.track(Event.TopSiteOpenFrecent) }
|
||||||
|
verify { metrics.track(Event.TopSiteOpenGoogle) }
|
||||||
verify {
|
verify {
|
||||||
tabsUseCases.addTab.invoke(
|
tabsUseCases.addTab.invoke(
|
||||||
SupportUtils.GOOGLE_XX_URL,
|
SupportUtils.GOOGLE_XX_URL,
|
||||||
|
@ -28,8 +28,8 @@ an hashed version of the Google Advertising ID.
|
|||||||
|
|
||||||
**Bugs related to this ping:**
|
**Bugs related to this ping:**
|
||||||
|
|
||||||
- 1538011
|
- <https://bugzilla.mozilla.com/1538011/>
|
||||||
- 1501822
|
- <https://bugzilla.mozilla.com/1501822/>
|
||||||
|
|
||||||
The following metrics are added to the ping:
|
The following metrics are added to the ping:
|
||||||
|
|
||||||
@ -221,6 +221,7 @@ The following metrics are added to the ping:
|
|||||||
| top_sites.long_press |[event](https://mozilla.github.io/glean/book/user/metrics/event.html) |A user long pressed on a top site |[1](https://github.com/mozilla-mobile/fenix/pull/15136), [2](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)|<ul><li>type: The type of top site. Options are: "FRECENCY," "DEFAULT," or "PINNED." </li></ul>|2021-08-01 |2 |
|
| top_sites.long_press |[event](https://mozilla.github.io/glean/book/user/metrics/event.html) |A user long pressed on a top site |[1](https://github.com/mozilla-mobile/fenix/pull/15136), [2](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)|<ul><li>type: The type of top site. Options are: "FRECENCY," "DEFAULT," or "PINNED." </li></ul>|2021-08-01 |2 |
|
||||||
| top_sites.open_default |[event](https://mozilla.github.io/glean/book/user/metrics/event.html) |A user opened a default top site |[1](https://github.com/mozilla-mobile/fenix/pull/10752), [2](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)||2021-08-01 |2 |
|
| top_sites.open_default |[event](https://mozilla.github.io/glean/book/user/metrics/event.html) |A user opened a default top site |[1](https://github.com/mozilla-mobile/fenix/pull/10752), [2](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)||2021-08-01 |2 |
|
||||||
| top_sites.open_frecency |[event](https://mozilla.github.io/glean/book/user/metrics/event.html) |A user opened a frecency top site |[1](https://github.com/mozilla-mobile/fenix/pull/15136), [2](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)||2021-08-01 |2 |
|
| top_sites.open_frecency |[event](https://mozilla.github.io/glean/book/user/metrics/event.html) |A user opened a frecency top site |[1](https://github.com/mozilla-mobile/fenix/pull/15136), [2](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)||2021-08-01 |2 |
|
||||||
|
| top_sites.open_google_search_attribution |[event](https://mozilla.github.io/glean/book/user/metrics/event.html) |A user opened the google top site |[1](https://github.com/mozilla-mobile/fenix/pull/17637)||2021-08-01 |2 |
|
||||||
| top_sites.open_in_new_tab |[event](https://mozilla.github.io/glean/book/user/metrics/event.html) |A user opens a new tab based on a top site item |[1](https://github.com/mozilla-mobile/fenix/pull/7523), [2](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)||2021-08-01 |2 |
|
| top_sites.open_in_new_tab |[event](https://mozilla.github.io/glean/book/user/metrics/event.html) |A user opens a new tab based on a top site item |[1](https://github.com/mozilla-mobile/fenix/pull/7523), [2](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)||2021-08-01 |2 |
|
||||||
| top_sites.open_in_private_tab |[event](https://mozilla.github.io/glean/book/user/metrics/event.html) |A user opens a new private tab based on a top site item |[1](https://github.com/mozilla-mobile/fenix/pull/7523), [2](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)||2021-08-01 |2 |
|
| top_sites.open_in_private_tab |[event](https://mozilla.github.io/glean/book/user/metrics/event.html) |A user opens a new private tab based on a top site item |[1](https://github.com/mozilla-mobile/fenix/pull/7523), [2](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)||2021-08-01 |2 |
|
||||||
| top_sites.open_pinned |[event](https://mozilla.github.io/glean/book/user/metrics/event.html) |A user opened a pinned top site |[1](https://github.com/mozilla-mobile/fenix/pull/15136), [2](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)||2021-08-01 |2 |
|
| top_sites.open_pinned |[event](https://mozilla.github.io/glean/book/user/metrics/event.html) |A user opened a pinned top site |[1](https://github.com/mozilla-mobile/fenix/pull/15136), [2](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)||2021-08-01 |2 |
|
||||||
|
Loading…
Reference in New Issue
Block a user