Archives/iceraven-browser
2
0
Fork 0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-19 09:25:34 +00:00
Code Issues Releases Wiki Activity

Bug 1853413 - Remove references to an old naming of the shopper footer as "byline"

Browse Source
This commit is contained in:
Noah Bond 2023-09-15 09:55:28 -07:00 committed by mergify[bot]
parent 2316c8a96d
commit a358384b2a
3 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/src/main/java/org/mozilla/fenix/shopping/ui/ProductAnalysis.kt
View File

@ -53,7 +53,7 @@ import org.mozilla.fenix.theme.FirefoxTheme
* @param onProductRecommendationsEnabledStateChange Invoked when the user changes the product * @param onProductRecommendationsEnabledStateChange Invoked when the user changes the product
* recommendations toggle state. * recommendations toggle state.
* @param onReviewGradeLearnMoreClick Invoked when the user clicks to learn more about review grades. * @param onReviewGradeLearnMoreClick Invoked when the user clicks to learn more about review grades.
* @param onBylineLinkClick Invoked when the user clicks on the byline link. * @param onFooterLinkClick Invoked when the user clicks on the footer link.
* @param modifier The modifier to be applied to the Composable. * @param modifier The modifier to be applied to the Composable.
*/ */
@Composable @Composable
@ -65,7 +65,7 @@ fun ProductAnalysis(
onReanalyzeClick: () -> Unit, onReanalyzeClick: () -> Unit,
onProductRecommendationsEnabledStateChange: (Boolean) -> Unit, onProductRecommendationsEnabledStateChange: (Boolean) -> Unit,
onReviewGradeLearnMoreClick: (String) -> Unit, onReviewGradeLearnMoreClick: (String) -> Unit,
onBylineLinkClick: (String) -> Unit, onFooterLinkClick: (String) -> Unit,
modifier: Modifier = Modifier, modifier: Modifier = Modifier,
) { ) {
Column( Column(
@ -126,7 +126,7 @@ fun ProductAnalysis(
) )
ReviewQualityCheckFooter( ReviewQualityCheckFooter(
onLinkClick = onBylineLinkClick, onLinkClick = onFooterLinkClick,
) )
} }
} }
@ -417,7 +417,7 @@ private fun ProductAnalysisPreview() {
productRecommendationsEnabled.value = it productRecommendationsEnabled.value = it
}, },
onReviewGradeLearnMoreClick = {}, onReviewGradeLearnMoreClick = {},
onBylineLinkClick = {}, onFooterLinkClick = {},
) )
} }
} }

8
app/src/main/java/org/mozilla/fenix/shopping/ui/ProductAnalysisError.kt
View File

@ -24,7 +24,7 @@ import org.mozilla.fenix.theme.FirefoxTheme
* @param onOptOutClick Invoked when the user opts out of the review quality check feature. * @param onOptOutClick Invoked when the user opts out of the review quality check feature.
* @param onProductRecommendationsEnabledStateChange Invoked when the user changes the product * @param onProductRecommendationsEnabledStateChange Invoked when the user changes the product
* recommendations toggle state. * recommendations toggle state.
* @param onBylineLinkClick Invoked when the user clicks on the byline link. * @param onFooterLinkClick Invoked when the user clicks on the footer link.
* @param modifier Modifier to apply to the layout. * @param modifier Modifier to apply to the layout.
*/ */
@Composable @Composable
@ -33,7 +33,7 @@ fun ProductAnalysisError(
onReviewGradeLearnMoreClick: (String) -> Unit, onReviewGradeLearnMoreClick: (String) -> Unit,
onOptOutClick: () -> Unit, onOptOutClick: () -> Unit,
onProductRecommendationsEnabledStateChange: (Boolean) -> Unit, onProductRecommendationsEnabledStateChange: (Boolean) -> Unit,
onBylineLinkClick: (String) -> Unit, onFooterLinkClick: (String) -> Unit,
modifier: Modifier = Modifier, modifier: Modifier = Modifier,
) { ) {
Column( Column(
@ -54,7 +54,7 @@ fun ProductAnalysisError(
) )
ReviewQualityCheckFooter( ReviewQualityCheckFooter(
onLinkClick = onBylineLinkClick, onLinkClick = onFooterLinkClick,
) )
} }
} }
@ -74,7 +74,7 @@ private fun ProductAnalysisErrorPreview() {
onReviewGradeLearnMoreClick = {}, onReviewGradeLearnMoreClick = {},
onOptOutClick = {}, onOptOutClick = {},
onProductRecommendationsEnabledStateChange = {}, onProductRecommendationsEnabledStateChange = {},
onBylineLinkClick = {}, onFooterLinkClick = {},
modifier = Modifier.fillMaxWidth(), modifier = Modifier.fillMaxWidth(),
) )
} }

8
app/src/main/java/org/mozilla/fenix/shopping/ui/ReviewQualityCheckBottomSheet.kt
View File

@ -69,7 +69,7 @@ fun ReviewQualityCheckBottomSheet(
), ),
) )
}, },
onBylineLinkClick = { url -> onFooterLinkClick = { url ->
store.dispatch( store.dispatch(
ReviewQualityCheckAction.OpenLink( ReviewQualityCheckAction.OpenLink(
ReviewQualityCheckState.LinkType.ExternalLink(url), ReviewQualityCheckState.LinkType.ExternalLink(url),
@ -98,7 +98,7 @@ private fun ProductReview(
onReanalyzeClick: () -> Unit, onReanalyzeClick: () -> Unit,
onProductRecommendationsEnabledStateChange: (Boolean) -> Unit, onProductRecommendationsEnabledStateChange: (Boolean) -> Unit,
onReviewGradeLearnMoreClick: (String) -> Unit, onReviewGradeLearnMoreClick: (String) -> Unit,
onBylineLinkClick: (String) -> Unit, onFooterLinkClick: (String) -> Unit,
) { ) {
Crossfade( Crossfade(
targetState = state.productReviewState, targetState = state.productReviewState,
@ -113,7 +113,7 @@ private fun ProductReview(
onReanalyzeClick = onReanalyzeClick, onReanalyzeClick = onReanalyzeClick,
onProductRecommendationsEnabledStateChange = onProductRecommendationsEnabledStateChange, onProductRecommendationsEnabledStateChange = onProductRecommendationsEnabledStateChange,
onReviewGradeLearnMoreClick = onReviewGradeLearnMoreClick, onReviewGradeLearnMoreClick = onReviewGradeLearnMoreClick,
onBylineLinkClick = onBylineLinkClick, onFooterLinkClick = onFooterLinkClick,
) )
} }
@ -123,7 +123,7 @@ private fun ProductReview(
onReviewGradeLearnMoreClick = onReviewGradeLearnMoreClick, onReviewGradeLearnMoreClick = onReviewGradeLearnMoreClick,
onOptOutClick = onOptOutClick, onOptOutClick = onOptOutClick,
onProductRecommendationsEnabledStateChange = onProductRecommendationsEnabledStateChange, onProductRecommendationsEnabledStateChange = onProductRecommendationsEnabledStateChange,
onBylineLinkClick = onBylineLinkClick, onFooterLinkClick = onFooterLinkClick,
modifier = Modifier.fillMaxWidth(), modifier = Modifier.fillMaxWidth(),
) )
} }