From a184fd480a056729a55be53abec03a5d80d2af2d Mon Sep 17 00:00:00 2001 From: mcarare <48995920+mcarare@users.noreply.github.com> Date: Wed, 30 Aug 2023 21:22:53 +0300 Subject: [PATCH] Bug 1850796 - Handle preferenceToScrollTo arg nullability. --- .../main/java/org/mozilla/fenix/settings/SettingsFragment.kt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt b/app/src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt index 5dbe5690b5..cfd2bf4107 100644 --- a/app/src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt @@ -178,9 +178,10 @@ class SettingsFragment : PreferenceFragmentCompat() { requireView().findViewById(R.id.recycler_view) ?.hideInitialScrollBar(viewLifecycleOwner.lifecycleScope) - if (args.preferenceToScrollTo != null) { - scrollToPreference(args.preferenceToScrollTo) + args.preferenceToScrollTo?.let { + scrollToPreference(it) } + // Consider finish of `onResume` to be the point at which we consider this fragment as 'created'. creatingFragment = false }