Archives/iceraven-browser
2
0
Fork 0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-19 09:25:34 +00:00
Code Issues Releases Wiki Activity

[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/11676: Features phone that doesn't a site permission exception shouldn't be shown (https://github.com/mozilla-mobile/fenix/pull/12855)

Browse Source 
exception shouldn't be shown
This commit is contained in:
Arturo Mejia 2020-07-23 12:12:22 -04:00 committed by GitHub
parent 69d6c450c5
commit 9f8851294b
2 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
app/src/main/java/org/mozilla/fenix/settings/quicksettings/ext/PhoneFeatureExt.kt
View File

@ -17,7 +17,15 @@ import org.mozilla.fenix.utils.Settings
fun PhoneFeature.shouldBeVisible(
sitePermissions: SitePermissions?,
settings: Settings
) = getStatus(sitePermissions, settings) != SitePermissions.Status.NO_DECISION
): Boolean {
// We have to check if the site have a site permission exception,
// if it doesn't the feature shouldn't be visible
return if (sitePermissions == null) {
false
} else {
getStatus(sitePermissions, settings) != SitePermissions.Status.NO_DECISION
}
}
/**
* Common [PhoneFeature] extensions used for **quicksettings**.

2
app/src/test/java/org/mozilla/fenix/settings/quicksettings/ext/PhoneFeatureExtKtTest.kt
View File

@ -27,6 +27,8 @@ class PhoneFeatureExtKtTest {
assertFalse(PhoneFeature.CAMERA.shouldBeVisible(noDecisionForPermission, mockk()))
assertTrue(PhoneFeature.CAMERA.shouldBeVisible(userAllowedPermission, mockk()))
assertTrue(PhoneFeature.CAMERA.shouldBeVisible(userBlockedPermission, mockk()))
// The site doesn't have a site permission exception
assertFalse(PhoneFeature.CAMERA.shouldBeVisible(null, mockk()))
}
@Test