From 9dd3c5d4c5cc34f63099baa9e6aa2068552523fe Mon Sep 17 00:00:00 2001 From: Noah Bond Date: Tue, 23 Aug 2022 14:50:08 -0700 Subject: [PATCH] [fenix] For https://github.com/mozilla-mobile/fenix/issues/26608 - Update recent bookmarks homepage title --- .../java/org/mozilla/fenix/ui/robots/HomeScreenRobot.kt | 2 +- .../java/org/mozilla/fenix/compose/home/HomeSectionHeader.kt | 2 +- .../recentbookmarks/view/RecentBookmarksHeaderViewHolder.kt | 2 +- app/src/main/res/values/strings.xml | 4 +++- 4 files changed, 6 insertions(+), 4 deletions(-) diff --git a/app/src/androidTest/java/org/mozilla/fenix/ui/robots/HomeScreenRobot.kt b/app/src/androidTest/java/org/mozilla/fenix/ui/robots/HomeScreenRobot.kt index 804a944d5..f57021d8e 100644 --- a/app/src/androidTest/java/org/mozilla/fenix/ui/robots/HomeScreenRobot.kt +++ b/app/src/androidTest/java/org/mozilla/fenix/ui/robots/HomeScreenRobot.kt @@ -730,7 +730,7 @@ private fun jumpBackInSection() = mDevice.findObject(UiSelector().textContains(getStringResource(R.string.recent_tabs_header))) private fun recentBookmarksSection() = - mDevice.findObject(UiSelector().textContains(getStringResource(R.string.recent_bookmarks_title))) + mDevice.findObject(UiSelector().textContains(getStringResource(R.string.recently_saved_title))) private fun startBrowsingButton(): UiObject { val startBrowsingButton = mDevice.findObject(UiSelector().resourceId("$packageName:id/finish_button")) diff --git a/app/src/main/java/org/mozilla/fenix/compose/home/HomeSectionHeader.kt b/app/src/main/java/org/mozilla/fenix/compose/home/HomeSectionHeader.kt index a500006bf..ec1b34ce4 100644 --- a/app/src/main/java/org/mozilla/fenix/compose/home/HomeSectionHeader.kt +++ b/app/src/main/java/org/mozilla/fenix/compose/home/HomeSectionHeader.kt @@ -114,7 +114,7 @@ private fun HomeSectionHeaderContent( private fun HomeSectionsHeaderPreview() { FirefoxTheme(theme = Theme.getTheme()) { HomeSectionHeader( - headerText = stringResource(R.string.recent_bookmarks_title), + headerText = stringResource(R.string.recently_saved_title), description = stringResource(R.string.recently_saved_show_all_content_description_2), onShowAllClick = {} ) diff --git a/app/src/main/java/org/mozilla/fenix/home/recentbookmarks/view/RecentBookmarksHeaderViewHolder.kt b/app/src/main/java/org/mozilla/fenix/home/recentbookmarks/view/RecentBookmarksHeaderViewHolder.kt index 83a9e30b6..d8063ffc0 100644 --- a/app/src/main/java/org/mozilla/fenix/home/recentbookmarks/view/RecentBookmarksHeaderViewHolder.kt +++ b/app/src/main/java/org/mozilla/fenix/home/recentbookmarks/view/RecentBookmarksHeaderViewHolder.kt @@ -51,7 +51,7 @@ class RecentBookmarksHeaderViewHolder( Spacer(modifier = Modifier.height(40.dp)) HomeSectionHeader( - headerText = stringResource(R.string.recent_bookmarks_title), + headerText = stringResource(R.string.recently_saved_title), description = stringResource(R.string.recently_saved_show_all_content_description_2), onShowAllClick = { dismissSearchDialogIfDisplayed() diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index ef8fb4fcf..93c1eb4d3 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -39,7 +39,9 @@ - Recent bookmarks + Recent bookmarks + + Recently saved Show all saved bookmarks