For #747: Fix memory leak with HomeMenu

nightly-build-test
Colin Lee 5 years ago committed by Jeff Boek
parent 28e2a62683
commit 9d3ef76929

@ -58,7 +58,7 @@ fun SessionBundleStorage.archive(sessionManager: SessionManager) {
class HomeFragment : Fragment() {
private val bus = ActionBusFactory.get(this)
private var sessionObserver: SessionManager.Observer? = null
private lateinit var homeMenu: HomeMenu
private var homeMenu: HomeMenu? = null
private lateinit var tabsComponent: TabsComponent
private lateinit var sessionsComponent: SessionsComponent
@ -114,7 +114,7 @@ class HomeFragment : Fragment() {
}
view.menuButton.setOnClickListener {
homeMenu.menuBuilder.build(requireContext()).show(
homeMenu?.menuBuilder?.build(requireContext())?.show(
anchor = it,
orientation = BrowserMenu.Orientation.DOWN)
}
@ -166,6 +166,11 @@ class HomeFragment : Fragment() {
}
}
override fun onDestroyView() {
super.onDestroyView()
homeMenu = null
}
override fun onResume() {
super.onResume()
(activity as AppCompatActivity).supportActionBar?.hide()

Loading…
Cancel
Save