From 9a78d339b50330012ed49bc9e3287b6ded1f4ccf Mon Sep 17 00:00:00 2001 From: Christian Sadilek Date: Tue, 14 Sep 2021 11:56:11 -0400 Subject: [PATCH] [fenix] Fix history metadata API breakage in unit tests --- .../HistoryMetadataFeatureTest.kt | 21 ++++++++++++------- .../HistoryMetadataControllerTest.kt | 6 ++++-- .../HistoryMetadataGroupViewHolderTest.kt | 3 ++- .../view/HistoryMetadataViewHolderTest.kt | 6 ++++-- .../fenix/home/HomeFragmentStoreTest.kt | 3 ++- .../home/SessionControlInteractorTest.kt | 6 ++++-- 6 files changed, 30 insertions(+), 15 deletions(-) diff --git a/app/src/test/java/org/mozilla/fenix/historymetadata/HistoryMetadataFeatureTest.kt b/app/src/test/java/org/mozilla/fenix/historymetadata/HistoryMetadataFeatureTest.kt index b6a4d8578..01701388a 100644 --- a/app/src/test/java/org/mozilla/fenix/historymetadata/HistoryMetadataFeatureTest.kt +++ b/app/src/test/java/org/mozilla/fenix/historymetadata/HistoryMetadataFeatureTest.kt @@ -52,7 +52,8 @@ class HistoryMetadataFeatureTest { createdAt = System.currentTimeMillis(), updatedAt = System.currentTimeMillis(), totalViewTime = 10, - documentType = DocumentType.Regular + documentType = DocumentType.Regular, + previewImageUrl = null ) val expectedHistoryGroup = HistoryMetadataGroup( title = "mozilla", @@ -81,7 +82,8 @@ class HistoryMetadataFeatureTest { createdAt = System.currentTimeMillis(), updatedAt = 1, totalViewTime = 10, - documentType = DocumentType.Regular + documentType = DocumentType.Regular, + previewImageUrl = null ) val historyEntry2 = HistoryMetadata( @@ -90,7 +92,8 @@ class HistoryMetadataFeatureTest { createdAt = System.currentTimeMillis(), updatedAt = 2, totalViewTime = 20, - documentType = DocumentType.Regular + documentType = DocumentType.Regular, + previewImageUrl = "http://firefox.com/image1" ) val historyEntry3 = HistoryMetadata( @@ -99,7 +102,8 @@ class HistoryMetadataFeatureTest { createdAt = System.currentTimeMillis(), updatedAt = 3, totalViewTime = 30, - documentType = DocumentType.Regular + documentType = DocumentType.Regular, + previewImageUrl = null ) val expectedHistoryGroup = HistoryMetadataGroup( @@ -136,7 +140,8 @@ class HistoryMetadataFeatureTest { createdAt = System.currentTimeMillis(), updatedAt = System.currentTimeMillis(), totalViewTime = 10, - documentType = DocumentType.Regular + documentType = DocumentType.Regular, + previewImageUrl = null ) val historyEntry2 = HistoryMetadata( @@ -145,7 +150,8 @@ class HistoryMetadataFeatureTest { createdAt = System.currentTimeMillis(), updatedAt = System.currentTimeMillis(), totalViewTime = 20, - documentType = DocumentType.Regular + documentType = DocumentType.Regular, + previewImageUrl = null ) val historyEntry3 = HistoryMetadata( @@ -154,7 +160,8 @@ class HistoryMetadataFeatureTest { createdAt = System.currentTimeMillis(), updatedAt = System.currentTimeMillis(), totalViewTime = 30, - documentType = DocumentType.Regular + documentType = DocumentType.Regular, + previewImageUrl = null ) val expectedHistoryGroup1 = HistoryMetadataGroup( diff --git a/app/src/test/java/org/mozilla/fenix/historymetadata/controller/HistoryMetadataControllerTest.kt b/app/src/test/java/org/mozilla/fenix/historymetadata/controller/HistoryMetadataControllerTest.kt index 854532102..cee861a3f 100644 --- a/app/src/test/java/org/mozilla/fenix/historymetadata/controller/HistoryMetadataControllerTest.kt +++ b/app/src/test/java/org/mozilla/fenix/historymetadata/controller/HistoryMetadataControllerTest.kt @@ -75,7 +75,8 @@ class HistoryMetadataControllerTest { createdAt = System.currentTimeMillis(), updatedAt = System.currentTimeMillis(), totalViewTime = 10, - documentType = DocumentType.Regular + documentType = DocumentType.Regular, + previewImageUrl = null ) controller.handleHistoryMetadataItemClicked(historyEntry.key.url, historyEntry.key) @@ -106,7 +107,8 @@ class HistoryMetadataControllerTest { createdAt = System.currentTimeMillis(), updatedAt = System.currentTimeMillis(), totalViewTime = 10, - documentType = DocumentType.Regular + documentType = DocumentType.Regular, + previewImageUrl = null ) val historyGroup = HistoryMetadataGroup( title = "mozilla", diff --git a/app/src/test/java/org/mozilla/fenix/historymetadata/view/HistoryMetadataGroupViewHolderTest.kt b/app/src/test/java/org/mozilla/fenix/historymetadata/view/HistoryMetadataGroupViewHolderTest.kt index 5522c48bb..93532ad3c 100644 --- a/app/src/test/java/org/mozilla/fenix/historymetadata/view/HistoryMetadataGroupViewHolderTest.kt +++ b/app/src/test/java/org/mozilla/fenix/historymetadata/view/HistoryMetadataGroupViewHolderTest.kt @@ -32,7 +32,8 @@ class HistoryMetadataGroupViewHolderTest { createdAt = System.currentTimeMillis(), updatedAt = System.currentTimeMillis(), totalViewTime = 10, - documentType = DocumentType.Regular + documentType = DocumentType.Regular, + previewImageUrl = null ) private val historyGroup = HistoryMetadataGroup( title = "mozilla", diff --git a/app/src/test/java/org/mozilla/fenix/historymetadata/view/HistoryMetadataViewHolderTest.kt b/app/src/test/java/org/mozilla/fenix/historymetadata/view/HistoryMetadataViewHolderTest.kt index e86431c51..da8567faf 100644 --- a/app/src/test/java/org/mozilla/fenix/historymetadata/view/HistoryMetadataViewHolderTest.kt +++ b/app/src/test/java/org/mozilla/fenix/historymetadata/view/HistoryMetadataViewHolderTest.kt @@ -35,7 +35,8 @@ class HistoryMetadataViewHolderTest { createdAt = System.currentTimeMillis(), updatedAt = System.currentTimeMillis(), totalViewTime = 10, - documentType = DocumentType.Regular + documentType = DocumentType.Regular, + previewImageUrl = null ) @Before @@ -74,7 +75,8 @@ class HistoryMetadataViewHolderTest { createdAt = System.currentTimeMillis(), updatedAt = System.currentTimeMillis(), totalViewTime = 10, - documentType = DocumentType.Regular + documentType = DocumentType.Regular, + previewImageUrl = null ) HistoryMetadataViewHolder(binding.root, interactor, icons).bind(historyEntryWithoutTitle) diff --git a/app/src/test/java/org/mozilla/fenix/home/HomeFragmentStoreTest.kt b/app/src/test/java/org/mozilla/fenix/home/HomeFragmentStoreTest.kt index 3f89d96f1..a28f2251d 100644 --- a/app/src/test/java/org/mozilla/fenix/home/HomeFragmentStoreTest.kt +++ b/app/src/test/java/org/mozilla/fenix/home/HomeFragmentStoreTest.kt @@ -131,7 +131,8 @@ class HomeFragmentStoreTest { createdAt = System.currentTimeMillis(), updatedAt = System.currentTimeMillis(), totalViewTime = 10, - documentType = DocumentType.Regular + documentType = DocumentType.Regular, + previewImageUrl = null ) val historyGroup = HistoryMetadataGroup( title = "mozilla", diff --git a/app/src/test/java/org/mozilla/fenix/home/SessionControlInteractorTest.kt b/app/src/test/java/org/mozilla/fenix/home/SessionControlInteractorTest.kt index 6a1043bae..31609fed6 100644 --- a/app/src/test/java/org/mozilla/fenix/home/SessionControlInteractorTest.kt +++ b/app/src/test/java/org/mozilla/fenix/home/SessionControlInteractorTest.kt @@ -167,7 +167,8 @@ class SessionControlInteractorTest { createdAt = System.currentTimeMillis(), updatedAt = System.currentTimeMillis(), totalViewTime = 10, - documentType = DocumentType.Regular + documentType = DocumentType.Regular, + previewImageUrl = null ) interactor.onHistoryMetadataItemClicked(historyEntry.key.url, historyEntry.key) @@ -193,7 +194,8 @@ class SessionControlInteractorTest { createdAt = System.currentTimeMillis(), updatedAt = System.currentTimeMillis(), totalViewTime = 10, - documentType = DocumentType.Regular + documentType = DocumentType.Regular, + previewImageUrl = null ) val historyGroup = HistoryMetadataGroup( title = "mozilla",