From 9817be4fd0248b25e0c6e71502bd78a80229fc1c Mon Sep 17 00:00:00 2001 From: Gabriel Luong Date: Sun, 13 Mar 2022 00:21:06 -0500 Subject: [PATCH] For #24252 - Rename foundation attribute to layer1 --- .../java/org/mozilla/fenix/library/LibraryPageFragment.kt | 2 +- .../java/org/mozilla/fenix/library/LibraryPageView.kt | 2 +- .../fenix/library/bookmarks/edit/EditBookmarkFragment.kt | 2 +- .../mozilla/fenix/library/history/toolbar/ToolbarView.kt | 2 +- .../mozilla/fenix/migration/MigrationProgressActivity.kt | 2 +- .../java/org/mozilla/fenix/search/toolbar/ToolbarView.kt | 2 +- .../main/java/org/mozilla/fenix/settings/SupportUtils.kt | 2 +- .../mozilla/fenix/tabhistory/TabHistoryDialogFragment.kt | 2 +- app/src/main/java/org/mozilla/fenix/theme/ThemeManager.kt | 2 +- app/src/main/res/drawable/ic_search_results_bookmarks.xml | 2 +- .../res/drawable/ic_search_results_device_desktop.xml | 2 +- .../main/res/drawable/ic_search_results_device_mobile.xml | 2 +- .../main/res/drawable/ic_search_results_device_tablet.xml | 2 +- app/src/main/res/drawable/ic_search_results_tab.xml | 2 +- .../res/drawable/search_pill_background_unselected.xml | 2 +- app/src/main/res/layout/bookmark_list_item.xml | 2 +- app/src/main/res/layout/component_collection_creation.xml | 2 +- .../component_collection_creation_name_collection.xml | 2 +- .../component_collection_creation_select_collection.xml | 2 +- .../res/layout/component_tracking_protection_panel.xml | 2 +- .../main/res/layout/connection_details_website_info.xml | 2 +- app/src/main/res/layout/download_dialog_layout.xml | 2 +- app/src/main/res/layout/fragment_browser.xml | 2 +- .../main/res/layout/fragment_history_search_dialog.xml | 4 ++-- .../res/layout/fragment_quick_settings_dialog_sheet.xml | 2 +- app/src/main/res/layout/fragment_search_dialog.xml | 6 +++--- app/src/main/res/layout/fragment_sign_out.xml | 2 +- app/src/main/res/layout/info_banner.xml | 2 +- app/src/main/res/layout/navigation_toolbar.xml | 2 +- app/src/main/res/layout/search_suggestions_hint.xml | 2 +- app/src/main/res/layout/stub_find_in_page.xml | 2 +- app/src/main/res/values-night-v23/styles.xml | 2 +- app/src/main/res/values-v23/styles.xml | 4 ++-- app/src/main/res/values-v27/styles.xml | 8 ++++---- app/src/main/res/values/attrs.xml | 3 ++- app/src/main/res/values/styles.xml | 6 ++++-- 36 files changed, 47 insertions(+), 44 deletions(-) diff --git a/app/src/main/java/org/mozilla/fenix/library/LibraryPageFragment.kt b/app/src/main/java/org/mozilla/fenix/library/LibraryPageFragment.kt index f3123d676..fd7883130 100644 --- a/app/src/main/java/org/mozilla/fenix/library/LibraryPageFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/library/LibraryPageFragment.kt @@ -41,7 +41,7 @@ abstract class LibraryPageFragment : Fragment() { context?.let { activity?.findViewById(R.id.navigationToolbar)?.setToolbarColors( it.getColorFromAttr(R.attr.textPrimary), - it.getColorFromAttr(R.attr.foundation) + it.getColorFromAttr(R.attr.layer1) ) } } diff --git a/app/src/main/java/org/mozilla/fenix/library/LibraryPageView.kt b/app/src/main/java/org/mozilla/fenix/library/LibraryPageView.kt index cf7596380..c94cd20f2 100644 --- a/app/src/main/java/org/mozilla/fenix/library/LibraryPageView.kt +++ b/app/src/main/java/org/mozilla/fenix/library/LibraryPageView.kt @@ -25,7 +25,7 @@ open class LibraryPageView( updateToolbar( title = title, foregroundColor = context.getColorFromAttr(R.attr.textPrimary), - backgroundColor = context.getColorFromAttr(R.attr.foundation) + backgroundColor = context.getColorFromAttr(R.attr.layer1) ) } diff --git a/app/src/main/java/org/mozilla/fenix/library/bookmarks/edit/EditBookmarkFragment.kt b/app/src/main/java/org/mozilla/fenix/library/bookmarks/edit/EditBookmarkFragment.kt index 8ec012e84..676aaafe3 100644 --- a/app/src/main/java/org/mozilla/fenix/library/bookmarks/edit/EditBookmarkFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/library/bookmarks/edit/EditBookmarkFragment.kt @@ -166,7 +166,7 @@ class EditBookmarkFragment : Fragment(R.layout.fragment_edit_bookmark) { val toolbar = activity.findViewById(R.id.navigationToolbar) toolbar?.setToolbarColors( foreground = activity.getColorFromAttr(R.attr.textPrimary), - background = activity.getColorFromAttr(R.attr.foundation) + background = activity.getColorFromAttr(R.attr.layer1) ) actionBar.show() } diff --git a/app/src/main/java/org/mozilla/fenix/library/history/toolbar/ToolbarView.kt b/app/src/main/java/org/mozilla/fenix/library/history/toolbar/ToolbarView.kt index 89db74929..b41345049 100644 --- a/app/src/main/java/org/mozilla/fenix/library/history/toolbar/ToolbarView.kt +++ b/app/src/main/java/org/mozilla/fenix/library/history/toolbar/ToolbarView.kt @@ -52,7 +52,7 @@ class ToolbarView( editMode() background = AppCompatResources.getDrawable( - context, context.theme.resolveAttribute(R.attr.foundation) + context, context.theme.resolveAttribute(R.attr.layer1) ) edit.hint = context.getString(R.string.history_search_1) diff --git a/app/src/main/java/org/mozilla/fenix/migration/MigrationProgressActivity.kt b/app/src/main/java/org/mozilla/fenix/migration/MigrationProgressActivity.kt index 8ff61ebd3..3b851d7cd 100644 --- a/app/src/main/java/org/mozilla/fenix/migration/MigrationProgressActivity.kt +++ b/app/src/main/java/org/mozilla/fenix/migration/MigrationProgressActivity.kt @@ -40,7 +40,7 @@ class MigrationProgressActivity : AbstractMigrationProgressActivity() { } fun init() { - window.navigationBarColor = getColorFromAttr(R.attr.foundation) + window.navigationBarColor = getColorFromAttr(R.attr.layer1) val appName = binding.migrationDescription.context.getString(R.string.app_name) diff --git a/app/src/main/java/org/mozilla/fenix/search/toolbar/ToolbarView.kt b/app/src/main/java/org/mozilla/fenix/search/toolbar/ToolbarView.kt index 0149a5949..df3750390 100644 --- a/app/src/main/java/org/mozilla/fenix/search/toolbar/ToolbarView.kt +++ b/app/src/main/java/org/mozilla/fenix/search/toolbar/ToolbarView.kt @@ -79,7 +79,7 @@ class ToolbarView( } background = AppCompatResources.getDrawable( - context, context.theme.resolveAttribute(R.attr.foundation) + context, context.theme.resolveAttribute(R.attr.layer1) ) edit.hint = context.getString(R.string.search_hint) diff --git a/app/src/main/java/org/mozilla/fenix/settings/SupportUtils.kt b/app/src/main/java/org/mozilla/fenix/settings/SupportUtils.kt index 4100ff835..9a297b576 100644 --- a/app/src/main/java/org/mozilla/fenix/settings/SupportUtils.kt +++ b/app/src/main/java/org/mozilla/fenix/settings/SupportUtils.kt @@ -103,7 +103,7 @@ object SupportUtils { fun createCustomTabIntent(context: Context, url: String): Intent = CustomTabsIntent.Builder() .setInstantAppsEnabled(false) .setDefaultColorSchemeParams( - CustomTabColorSchemeParams.Builder().setToolbarColor(context.getColorFromAttr(R.attr.foundation)).build() + CustomTabColorSchemeParams.Builder().setToolbarColor(context.getColorFromAttr(R.attr.layer1)).build() ) .build() .intent diff --git a/app/src/main/java/org/mozilla/fenix/tabhistory/TabHistoryDialogFragment.kt b/app/src/main/java/org/mozilla/fenix/tabhistory/TabHistoryDialogFragment.kt index 62e706e4e..7dfce1b46 100644 --- a/app/src/main/java/org/mozilla/fenix/tabhistory/TabHistoryDialogFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/tabhistory/TabHistoryDialogFragment.kt @@ -37,7 +37,7 @@ class TabHistoryDialogFragment : BottomSheetDialogFragment() { val binding = FragmentTabHistoryDialogBinding.bind(view) - view.setBackgroundColor(view.context.getColorFromAttr(R.attr.foundation)) + view.setBackgroundColor(view.context.getColorFromAttr(R.attr.layer1)) customTabSessionId = requireArguments().getString(EXTRA_SESSION_ID) diff --git a/app/src/main/java/org/mozilla/fenix/theme/ThemeManager.kt b/app/src/main/java/org/mozilla/fenix/theme/ThemeManager.kt index 4c89e68bb..4977b997c 100644 --- a/app/src/main/java/org/mozilla/fenix/theme/ThemeManager.kt +++ b/app/src/main/java/org/mozilla/fenix/theme/ThemeManager.kt @@ -109,7 +109,7 @@ abstract class ThemeManager { } private fun updateNavigationBar(window: Window, context: Context) { - window.navigationBarColor = context.getColorFromAttr(R.attr.foundation) + window.navigationBarColor = context.getColorFromAttr(R.attr.layer1) } } } diff --git a/app/src/main/res/drawable/ic_search_results_bookmarks.xml b/app/src/main/res/drawable/ic_search_results_bookmarks.xml index 4bf1e5c91..546da504d 100644 --- a/app/src/main/res/drawable/ic_search_results_bookmarks.xml +++ b/app/src/main/res/drawable/ic_search_results_bookmarks.xml @@ -7,7 +7,7 @@ android:width="16dp" android:viewportHeight="20" android:viewportWidth="20"> - diff --git a/app/src/main/res/drawable/ic_search_results_device_desktop.xml b/app/src/main/res/drawable/ic_search_results_device_desktop.xml index 3f028b995..c53b9d514 100644 --- a/app/src/main/res/drawable/ic_search_results_device_desktop.xml +++ b/app/src/main/res/drawable/ic_search_results_device_desktop.xml @@ -7,7 +7,7 @@ android:width="16dp" android:viewportHeight="20" android:viewportWidth="20"> - diff --git a/app/src/main/res/drawable/ic_search_results_device_mobile.xml b/app/src/main/res/drawable/ic_search_results_device_mobile.xml index 83d6999b3..a9888f201 100644 --- a/app/src/main/res/drawable/ic_search_results_device_mobile.xml +++ b/app/src/main/res/drawable/ic_search_results_device_mobile.xml @@ -7,7 +7,7 @@ android:width="16dp" android:viewportHeight="20" android:viewportWidth="20"> - diff --git a/app/src/main/res/drawable/ic_search_results_device_tablet.xml b/app/src/main/res/drawable/ic_search_results_device_tablet.xml index 276cc2b33..c30893821 100644 --- a/app/src/main/res/drawable/ic_search_results_device_tablet.xml +++ b/app/src/main/res/drawable/ic_search_results_device_tablet.xml @@ -7,7 +7,7 @@ android:width="16dp" android:viewportHeight="20" android:viewportWidth="20"> - diff --git a/app/src/main/res/drawable/ic_search_results_tab.xml b/app/src/main/res/drawable/ic_search_results_tab.xml index c290b982f..ddb1c4811 100644 --- a/app/src/main/res/drawable/ic_search_results_tab.xml +++ b/app/src/main/res/drawable/ic_search_results_tab.xml @@ -7,7 +7,7 @@ android:width="16dp" android:viewportHeight="20" android:viewportWidth="20"> - diff --git a/app/src/main/res/drawable/search_pill_background_unselected.xml b/app/src/main/res/drawable/search_pill_background_unselected.xml index 3dcb10d78..b66f68bd3 100644 --- a/app/src/main/res/drawable/search_pill_background_unselected.xml +++ b/app/src/main/res/drawable/search_pill_background_unselected.xml @@ -3,6 +3,6 @@ - License, v. 2.0. If a copy of the MPL was not distributed with this - file, You can obtain one at http://mozilla.org/MPL/2.0/. --> - + diff --git a/app/src/main/res/layout/bookmark_list_item.xml b/app/src/main/res/layout/bookmark_list_item.xml index ee42f2c06..14080e836 100644 --- a/app/src/main/res/layout/bookmark_list_item.xml +++ b/app/src/main/res/layout/bookmark_list_item.xml @@ -5,4 +5,4 @@ + android:background="?attr/layer1" /> diff --git a/app/src/main/res/layout/component_collection_creation.xml b/app/src/main/res/layout/component_collection_creation.xml index 098f88496..7cbe565ea 100644 --- a/app/src/main/res/layout/component_collection_creation.xml +++ b/app/src/main/res/layout/component_collection_creation.xml @@ -117,7 +117,7 @@ android:layout_height="wrap_content" android:layout_gravity="bottom|center" android:autofillHints="false" - android:background="?foundation" + android:background="?attr/layer1" android:focusedByDefault="true" android:hint="@string/collection_name_hint" android:imeOptions="actionDone" diff --git a/app/src/main/res/layout/component_collection_creation_name_collection.xml b/app/src/main/res/layout/component_collection_creation_name_collection.xml index 7232df8bc..2f9ef68a2 100644 --- a/app/src/main/res/layout/component_collection_creation_name_collection.xml +++ b/app/src/main/res/layout/component_collection_creation_name_collection.xml @@ -60,7 +60,7 @@ android:layout_gravity="bottom|center" android:alpha="1" android:autofillHints="false" - android:background="?foundation" + android:background="?attr/layer1" android:focusedByDefault="true" android:hint="@string/collection_name_hint" android:imeOptions="actionDone" diff --git a/app/src/main/res/layout/component_collection_creation_select_collection.xml b/app/src/main/res/layout/component_collection_creation_select_collection.xml index 05cc8907a..69292d2e4 100644 --- a/app/src/main/res/layout/component_collection_creation_select_collection.xml +++ b/app/src/main/res/layout/component_collection_creation_select_collection.xml @@ -64,7 +64,7 @@ android:layout_gravity="bottom|center" android:alpha="0" android:autofillHints="false" - android:background="?foundation" + android:background="?attr/layer1" android:focusedByDefault="true" android:hint="@string/collection_name_hint" android:imeOptions="actionDone" diff --git a/app/src/main/res/layout/component_tracking_protection_panel.xml b/app/src/main/res/layout/component_tracking_protection_panel.xml index e5d258f9d..fa89f6631 100644 --- a/app/src/main/res/layout/component_tracking_protection_panel.xml +++ b/app/src/main/res/layout/component_tracking_protection_panel.xml @@ -10,7 +10,7 @@ android:id="@+id/panel_wrapper" android:layout_width="match_parent" android:layout_height="wrap_content" - android:background="?foundation"> + android:background="?attr/layer1"> diff --git a/app/src/main/res/layout/fragment_history_search_dialog.xml b/app/src/main/res/layout/fragment_history_search_dialog.xml index dc6f27014..47d157667 100644 --- a/app/src/main/res/layout/fragment_history_search_dialog.xml +++ b/app/src/main/res/layout/fragment_history_search_dialog.xml @@ -68,7 +68,7 @@ android:fadingEdgeLength="40dp" android:nestedScrollingEnabled="false" android:requiresFadingEdge="vertical" - android:background="?attr/foundation" + android:background="?attr/layer1" android:visibility="invisible" app:layout_constraintBottom_toTopOf="@+id/pill_wrapper" app:layout_constraintEnd_toEndOf="parent" @@ -98,7 +98,7 @@ android:id="@+id/pill_wrapper" android:layout_width="0dp" android:layout_height="0dp" - android:background="?foundation" + android:background="?attr/layer1" android:importantForAccessibility="no" android:paddingStart="@dimen/search_fragment_pill_padding_start" android:paddingTop="@dimen/search_fragment_pill_padding_vertical" diff --git a/app/src/main/res/layout/fragment_quick_settings_dialog_sheet.xml b/app/src/main/res/layout/fragment_quick_settings_dialog_sheet.xml index 7247517f8..74ae6fea5 100644 --- a/app/src/main/res/layout/fragment_quick_settings_dialog_sheet.xml +++ b/app/src/main/res/layout/fragment_quick_settings_dialog_sheet.xml @@ -14,7 +14,7 @@ android:id="@+id/quick_action_sheet" android:layout_width="match_parent" android:layout_height="wrap_content" - android:background="?foundation"> + android:background="?attr/layer1"> diff --git a/app/src/main/res/layout/navigation_toolbar.xml b/app/src/main/res/layout/navigation_toolbar.xml index 4880bbf0b..e5c23f800 100644 --- a/app/src/main/res/layout/navigation_toolbar.xml +++ b/app/src/main/res/layout/navigation_toolbar.xml @@ -11,7 +11,7 @@ app:titleMarginStart="16dp" app:titleMarginEnd="16dp" app:titleTextAppearance="@style/ToolbarTitleTextStyle" - android:background="?foundation" + android:background="?attr/layer1" android:elevation="8dp"> false - ?foundation + ?attr/layer1 \ No newline at end of file diff --git a/app/src/main/res/values-v27/styles.xml b/app/src/main/res/values-v27/styles.xml index b62141130..cd4dccd1a 100644 --- a/app/src/main/res/values-v27/styles.xml +++ b/app/src/main/res/values-v27/styles.xml @@ -28,8 +28,8 @@