From 95c9a2412c85acf325a07ee643e99946097f5497 Mon Sep 17 00:00:00 2001 From: Arturo Mejia Date: Fri, 6 May 2022 14:48:27 -0400 Subject: [PATCH] [fenix] For https://github.com/mozilla-mobile/fenix/issues/25142 increase the EXPECTED_RECYCLER_VIEW_CONSTRAINT_LAYOUT_CHILDREN to count for the messaging framework message. --- .../fenix/perf/StartupExcessiveResourceUseTest.kt | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/app/src/androidTest/java/org/mozilla/fenix/perf/StartupExcessiveResourceUseTest.kt b/app/src/androidTest/java/org/mozilla/fenix/perf/StartupExcessiveResourceUseTest.kt index 577e7ba65e..d44582a03d 100644 --- a/app/src/androidTest/java/org/mozilla/fenix/perf/StartupExcessiveResourceUseTest.kt +++ b/app/src/androidTest/java/org/mozilla/fenix/perf/StartupExcessiveResourceUseTest.kt @@ -24,7 +24,8 @@ import org.mozilla.fenix.helpers.HomeActivityTestRule private const val EXPECTED_SUPPRESSION_COUNT = 19 @Suppress("TopLevelPropertyNaming") // it's silly this would have a different naming convention b/c no const private val EXPECTED_RUNBLOCKING_RANGE = 0..1 // CI has +1 counts compared to local runs: increment these together -private const val EXPECTED_RECYCLER_VIEW_CONSTRAINT_LAYOUT_CHILDREN = 4 +private val EXPECTED_RECYCLER_VIEW_CONSTRAINT_LAYOUT_CHILDREN = + 4..5 // The messaging framework is not deterministic and could add a +1 to the count private const val EXPECTED_NUMBER_OF_INFLATION = 14 private val failureMsgStrictMode = getErrorMessage( @@ -87,10 +88,9 @@ class StartupExcessiveResourceUseTest { assertEquals(failureMsgStrictMode, EXPECTED_SUPPRESSION_COUNT, actualSuppresionCount) assertTrue(failureMsgRunBlocking + "actual: $actualRunBlocking", actualRunBlocking in EXPECTED_RUNBLOCKING_RANGE) - assertEquals( - failureMsgRecyclerViewConstraintLayoutChildren, - EXPECTED_RECYCLER_VIEW_CONSTRAINT_LAYOUT_CHILDREN, - actualRecyclerViewConstraintLayoutChildren + assertTrue( + failureMsgRecyclerViewConstraintLayoutChildren + "actual: $actualRunBlocking", + actualRecyclerViewConstraintLayoutChildren in EXPECTED_RECYCLER_VIEW_CONSTRAINT_LAYOUT_CHILDREN, ) assertEquals(failureMsgNumberOfInflation, EXPECTED_NUMBER_OF_INFLATION, actualNumberOfInflations) }