For #25379 - Plug FenixTypography into ListItem, Button, TextButton, and ExpandableListHeader

pull/543/head
Noah Bond 2 years ago committed by mergify[bot]
parent 4c118f4816
commit 9520b8c1f3

@ -23,7 +23,6 @@ import androidx.compose.ui.graphics.painter.Painter
import androidx.compose.ui.res.painterResource import androidx.compose.ui.res.painterResource
import androidx.compose.ui.tooling.preview.Preview import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.unit.dp import androidx.compose.ui.unit.dp
import androidx.compose.ui.unit.sp
import org.mozilla.fenix.R import org.mozilla.fenix.R
import org.mozilla.fenix.theme.FirefoxTheme import org.mozilla.fenix.theme.FirefoxTheme
import org.mozilla.fenix.theme.Theme import org.mozilla.fenix.theme.Theme
@ -70,8 +69,7 @@ fun Button(
Text( Text(
text = text, text = text,
color = textColor, color = textColor,
fontSize = 14.sp, style = FirefoxTheme.typography.button,
letterSpacing = 0.25.sp,
maxLines = 1, maxLines = 1,
) )
} }

@ -11,10 +11,7 @@ import androidx.compose.material.Text
import androidx.compose.runtime.Composable import androidx.compose.runtime.Composable
import androidx.compose.ui.Modifier import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.Color import androidx.compose.ui.graphics.Color
import androidx.compose.ui.text.TextStyle
import androidx.compose.ui.text.font.FontWeight
import androidx.compose.ui.tooling.preview.Preview import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.unit.sp
import org.mozilla.fenix.theme.FirefoxTheme import org.mozilla.fenix.theme.FirefoxTheme
import org.mozilla.fenix.theme.Theme import org.mozilla.fenix.theme.Theme
import java.util.Locale import java.util.Locale
@ -40,13 +37,8 @@ fun TextButton(
) { ) {
Text( Text(
text = text.uppercase(Locale.getDefault()), text = text.uppercase(Locale.getDefault()),
style = TextStyle(
color = textColor, color = textColor,
fontSize = 14.sp, style = FirefoxTheme.typography.button,
fontWeight = FontWeight.Medium,
letterSpacing = 0.25.sp,
lineHeight = 14.sp,
),
maxLines = 1, maxLines = 1,
) )
} }

@ -15,17 +15,14 @@ import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.size import androidx.compose.foundation.layout.size
import androidx.compose.foundation.layout.width import androidx.compose.foundation.layout.width
import androidx.compose.material.Icon import androidx.compose.material.Icon
import androidx.compose.material.Text
import androidx.compose.runtime.Composable import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier import androidx.compose.ui.Modifier
import androidx.compose.ui.res.painterResource import androidx.compose.ui.res.painterResource
import androidx.compose.ui.text.font.Font
import androidx.compose.ui.text.font.FontFamily
import androidx.compose.ui.tooling.preview.Preview import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.unit.dp import androidx.compose.ui.unit.dp
import androidx.compose.ui.unit.sp
import org.mozilla.fenix.R import org.mozilla.fenix.R
import org.mozilla.fenix.compose.PrimaryText
import org.mozilla.fenix.theme.FirefoxTheme import org.mozilla.fenix.theme.FirefoxTheme
import org.mozilla.fenix.theme.Theme import org.mozilla.fenix.theme.Theme
@ -64,10 +61,10 @@ fun ExpandableListHeader(
.padding(horizontal = 16.dp, vertical = 8.dp), .padding(horizontal = 16.dp, vertical = 8.dp),
verticalAlignment = Alignment.CenterVertically, verticalAlignment = Alignment.CenterVertically,
) { ) {
PrimaryText( Text(
text = headerText, text = headerText,
fontSize = 14.sp, color = FirefoxTheme.colors.textPrimary,
fontFamily = FontFamily(Font(R.font.metropolis_semibold)), style = FirefoxTheme.typography.headline8,
maxLines = 1, maxLines = 1,
) )

@ -16,6 +16,7 @@ import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.size import androidx.compose.foundation.layout.size
import androidx.compose.material.Icon import androidx.compose.material.Icon
import androidx.compose.material.IconButton import androidx.compose.material.IconButton
import androidx.compose.material.Text
import androidx.compose.runtime.Composable import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier import androidx.compose.ui.Modifier
@ -23,11 +24,8 @@ import androidx.compose.ui.graphics.painter.Painter
import androidx.compose.ui.res.painterResource import androidx.compose.ui.res.painterResource
import androidx.compose.ui.tooling.preview.Preview import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.unit.dp import androidx.compose.ui.unit.dp
import androidx.compose.ui.unit.sp
import org.mozilla.fenix.R import org.mozilla.fenix.R
import org.mozilla.fenix.compose.Favicon import org.mozilla.fenix.compose.Favicon
import org.mozilla.fenix.compose.PrimaryText
import org.mozilla.fenix.compose.SecondaryText
import org.mozilla.fenix.theme.FirefoxTheme import org.mozilla.fenix.theme.FirefoxTheme
import org.mozilla.fenix.theme.Theme import org.mozilla.fenix.theme.Theme
@ -228,16 +226,18 @@ private fun ListItem(
.padding(horizontal = 16.dp, vertical = 6.dp) .padding(horizontal = 16.dp, vertical = 6.dp)
.weight(1f), .weight(1f),
) { ) {
PrimaryText( Text(
text = label, text = label,
fontSize = 16.sp, color = FirefoxTheme.colors.textPrimary,
style = FirefoxTheme.typography.subtitle1,
maxLines = 1, maxLines = 1,
) )
description?.let { description?.let {
SecondaryText( Text(
text = description, text = description,
fontSize = 14.sp, color = FirefoxTheme.colors.textSecondary,
style = FirefoxTheme.typography.body2,
maxLines = maxDescriptionLines, maxLines = maxDescriptionLines,
) )
} }

Loading…
Cancel
Save