From 9434f01b429b5e44fdb317ae7212982057ce4f51 Mon Sep 17 00:00:00 2001
From: Jeff Boek <jeff@jeffboek.com>
Date: Mon, 8 Apr 2019 13:48:37 -0700
Subject: [PATCH] Fixes #1204 - Fixes the home screen animation

---
 .../org/mozilla/fenix/home/HomeFragment.kt    |  3 ++
 .../main/res/drawable/home_header_shadow.xml  |  7 ++++
 app/src/main/res/layout/fragment_home.xml     | 10 ++++++
 app/src/main/res/values/colors.xml            |  2 ++
 app/src/main/res/xml/home_scene.xml           | 33 +++++++++++++++++++
 5 files changed, 55 insertions(+)
 create mode 100644 app/src/main/res/drawable/home_header_shadow.xml

diff --git a/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt b/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt
index a527dd55a..d050fe455 100644
--- a/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt
+++ b/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt
@@ -153,6 +153,9 @@ class HomeFragment : Fragment(), CoroutineScope {
                 BrowsingModeManager.Mode.Private -> BrowsingModeManager.Mode.Normal
             }
         }
+
+        // We need the shadow to be above the components.
+        homeDividerShadow.bringToFront()
     }
 
     override fun onDestroyView() {
diff --git a/app/src/main/res/drawable/home_header_shadow.xml b/app/src/main/res/drawable/home_header_shadow.xml
new file mode 100644
index 000000000..e3bf7a297
--- /dev/null
+++ b/app/src/main/res/drawable/home_header_shadow.xml
@@ -0,0 +1,7 @@
+<?xml version="1.0" encoding="utf-8"?>
+<shape xmlns:android="http://schemas.android.com/apk/res/android">
+    <gradient
+        android:startColor="@color/home_header_shadow"
+        android:endColor="@android:color/transparent"
+        android:angle="270" />
+</shape>
diff --git a/app/src/main/res/layout/fragment_home.xml b/app/src/main/res/layout/fragment_home.xml
index d9779c86f..bf502474e 100644
--- a/app/src/main/res/layout/fragment_home.xml
+++ b/app/src/main/res/layout/fragment_home.xml
@@ -89,5 +89,15 @@
             android:layout_marginStart="40dp"
             android:layout_marginEnd="40dp"/>
 
+        <View
+            android:id="@+id/homeDividerShadow"
+            android:layout_width="0dp"
+            android:layout_height="3dp"
+            android:alpha="0"
+            android:background="@drawable/home_header_shadow"
+            app:layout_constraintTop_toBottomOf="@id/homeDivider"
+            app:layout_constraintStart_toStartOf="@+id/homeDivider"
+            app:layout_constraintEnd_toEndOf="@+id/homeDivider" />
+
     </androidx.constraintlayout.motion.widget.MotionLayout>
 </androidx.coordinatorlayout.widget.CoordinatorLayout>
\ No newline at end of file
diff --git a/app/src/main/res/values/colors.xml b/app/src/main/res/values/colors.xml
index a82eacad0..b1990043e 100644
--- a/app/src/main/res/values/colors.xml
+++ b/app/src/main/res/values/colors.xml
@@ -140,4 +140,6 @@
     <color name="quick_action_background_private_theme">@color/toolbar_dark_mode</color>
 
     <color name="fenix_snackbar_background">#232749</color>
+
+    <color name="home_header_shadow">#1F1B215E</color>
 </resources>
diff --git a/app/src/main/res/xml/home_scene.xml b/app/src/main/res/xml/home_scene.xml
index deca9d0fb..431f92de6 100644
--- a/app/src/main/res/xml/home_scene.xml
+++ b/app/src/main/res/xml/home_scene.xml
@@ -50,6 +50,21 @@
                 motion:framePosition="90"
                 android:alpha="0" />
 
+            <KeyAttribute
+                motion:motionTarget="@id/homeDividerShadow"
+                motion:framePosition="90">
+                <CustomAttribute
+                    motion:attributeName="layoutMarginStart"
+                    motion:customPixelDimension="0dp" />
+                <CustomAttribute
+                    motion:attributeName="layoutMarginEnd"
+                    motion:customPixelDimension="0dp" />
+            </KeyAttribute>
+            <KeyAttribute
+                motion:motionTarget="@id/homeDividerShadow"
+                motion:framePosition="90"
+                android:alpha="0" />
+
             <KeyAttribute
                 motion:motionTarget="@id/toolbar_wrapper"
                 motion:framePosition="0"
@@ -120,5 +135,23 @@
             android:layout_width="@dimen/glyph_button_height"
             motion:layout_constraintEnd_toStartOf="@id/menuButton"
             motion:layout_constraintTop_toTopOf="@id/menuButton"/>
+
+        <Constraint
+            android:id="@+id/homeDivider"
+            android:layout_height="1dp"
+            android:layout_marginStart="0dp"
+            android:layout_marginEnd="0dp"
+            android:layout_marginTop="8dp"
+            motion:layout_constraintTop_toBottomOf="@id/toolbar_wrapper"
+            motion:layout_constraintStart_toStartOf="parent"
+            motion:layout_constraintEnd_toEndOf="parent" />
+
+        <Constraint
+            android:id="@+id/homeDividerShadow"
+            android:layout_height="3dp"
+            android:alpha="1"
+            motion:layout_constraintTop_toBottomOf="@id/homeDivider"
+            motion:layout_constraintStart_toStartOf="@+id/homeDivider"
+            motion:layout_constraintEnd_toEndOf="@+id/homeDivider" />
     </ConstraintSet>
 </MotionScene>