From 8e3fa7dfc710b71aa4bd86f78a237c614a6745a3 Mon Sep 17 00:00:00 2001 From: Jonathan Almeida Date: Fri, 26 Jun 2020 20:46:23 -0400 Subject: [PATCH] [fenix] For https://github.com/mozilla-mobile/fenix/issues/12002: Show default tab background when thumbnail not available (https://github.com/mozilla-mobile/fenix/pull/12041) --- app/src/main/res/layout/tab_tray_item.xml | 10 ++++++++++ app/src/main/res/values-night/colors.xml | 2 ++ app/src/main/res/values/attrs.xml | 2 ++ app/src/main/res/values/colors.xml | 6 ++++++ app/src/main/res/values/styles.xml | 4 ++++ 5 files changed, 24 insertions(+) diff --git a/app/src/main/res/layout/tab_tray_item.xml b/app/src/main/res/layout/tab_tray_item.xml index 3386313458..0a465794e9 100644 --- a/app/src/main/res/layout/tab_tray_item.xml +++ b/app/src/main/res/layout/tab_tray_item.xml @@ -29,10 +29,20 @@ android:layout_height="69dp" android:layout_marginStart="16dp" android:layout_marginTop="8dp" + android:backgroundTint="?tabTrayThumbnailItemBackground" app:cardBackgroundColor="@color/photonWhite" app:layout_constraintStart_toStartOf="parent" app:layout_constraintTop_toTopOf="parent"> + + @color/tab_tray_item_media_background_dark_theme @color/tab_tray_heading_icon_dark_theme @color/tab_tray_heading_icon_inactive_dark_theme + @color/tab_tray_item_thumbnail_background_dark_theme + @color/tab_tray_item_thumbnail_icon_dark_theme @color/top_site_background_dark_theme diff --git a/app/src/main/res/values/attrs.xml b/app/src/main/res/values/attrs.xml index 87849a68d5..305e19826f 100644 --- a/app/src/main/res/values/attrs.xml +++ b/app/src/main/res/values/attrs.xml @@ -60,6 +60,8 @@ + + diff --git a/app/src/main/res/values/colors.xml b/app/src/main/res/values/colors.xml index 9501623c05..2efbf79d84 100644 --- a/app/src/main/res/values/colors.xml +++ b/app/src/main/res/values/colors.xml @@ -83,6 +83,8 @@ #312A65 @color/ink_20 @color/ink_20_48a + @color/light_grey_10 + @color/light_grey_60 #FBFBFE @@ -140,6 +142,8 @@ #9059FF @color/violet_50 @color/violet_50_48a + @color/dark_grey_50 + @color/dark_grey_05 #FBFBFE @@ -243,6 +247,8 @@ @color/tab_tray_item_media_background_light_theme @color/tab_tray_heading_icon_light_theme @color/tab_tray_heading_icon_inactive_light_theme + @color/tab_tray_item_thumbnail_background_light_theme + @color/tab_tray_item_thumbnail_icon_light_theme #DFDFE3 diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml index 567f6ade1b..961374f94a 100644 --- a/app/src/main/res/values/styles.xml +++ b/app/src/main/res/values/styles.xml @@ -84,6 +84,8 @@ @color/tab_tray_item_media_background_normal_theme @color/tab_tray_heading_icon_normal_theme @color/tab_tray_heading_icon_inactive_normal_theme + @color/tab_tray_item_thumbnail_background_normal_theme + @color/tab_tray_item_thumbnail_icon_normal_theme @drawable/ic_logo_wordmark_normal @@ -209,6 +211,8 @@ @color/tab_tray_item_media_background_private_theme @color/tab_tray_heading_icon_dark_theme @color/tab_tray_heading_icon_inactive_dark_theme + @color/tab_tray_item_thumbnail_background_normal_theme + @color/tab_tray_item_thumbnail_icon_normal_theme @drawable/ic_logo_wordmark_private