From 8b20c2d8c227656a91f581fb1c55faf26e6771c9 Mon Sep 17 00:00:00 2001 From: Michael Comella Date: Tue, 6 Oct 2020 13:18:50 -0700 Subject: [PATCH] [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 - post: decrement expected suppression count. Running locally, I get the same error: I think that there legitimately was an reduction in the number of StrictMode suppressions on start up. --- .../fenix/ui/StrictModeStartupSuppressionCountTest.kt | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/app/src/androidTest/java/org/mozilla/fenix/ui/StrictModeStartupSuppressionCountTest.kt b/app/src/androidTest/java/org/mozilla/fenix/ui/StrictModeStartupSuppressionCountTest.kt index 800d81f6c3..ece75c63d3 100644 --- a/app/src/androidTest/java/org/mozilla/fenix/ui/StrictModeStartupSuppressionCountTest.kt +++ b/app/src/androidTest/java/org/mozilla/fenix/ui/StrictModeStartupSuppressionCountTest.kt @@ -13,9 +13,12 @@ import org.mozilla.fenix.ext.components import org.mozilla.fenix.helpers.HomeActivityTestRule // PLEASE CONSULT WITH PERF TEAM BEFORE CHANGING THIS VALUE. -private const val EXPECTED_SUPPRESSION_COUNT = 12 +private const val EXPECTED_SUPPRESSION_COUNT = 11 private const val FAILURE_MSG = """StrictMode startup suppression count does not match expected count. + + If this PR removed code that suppressed StrictMode, great! Please decrement the suppression count. + Did this PR add or call code that suppresses a StrictMode violation? Did you know that suppressing a StrictMode violation can introduce performance regressions? @@ -23,8 +26,6 @@ private const val FAILURE_MSG = """StrictMode startup suppression count does not Please consult the perf team if you have questions or believe suppressing StrictMode is the optimal solution. - If this PR removed code that suppressed StrictMode, great! Please decrement the suppression count. - """ /**