From 867f11e5d9b160b7da5645d5c7b43d47981164e8 Mon Sep 17 00:00:00 2001 From: AndiAJ Date: Fri, 29 Oct 2021 16:07:21 +0300 Subject: [PATCH] [fenix] Improve coverage for cancelCreateBookmarkFolderTest UI test --- .../java/org/mozilla/fenix/ui/BookmarksTest.kt | 1 + .../mozilla/fenix/ui/robots/BookmarksRobot.kt | 17 +++++++++++++++++ 2 files changed, 18 insertions(+) diff --git a/app/src/androidTest/java/org/mozilla/fenix/ui/BookmarksTest.kt b/app/src/androidTest/java/org/mozilla/fenix/ui/BookmarksTest.kt index 98be189808..3bca1cfb4f 100644 --- a/app/src/androidTest/java/org/mozilla/fenix/ui/BookmarksTest.kt +++ b/app/src/androidTest/java/org/mozilla/fenix/ui/BookmarksTest.kt @@ -166,6 +166,7 @@ class BookmarksTest { addNewFolderName(bookmarksFolderName) navigateUp() verifyKeyboardHidden() + verifyBookmarkFolderIsNotCreated(bookmarksFolderName) } } diff --git a/app/src/androidTest/java/org/mozilla/fenix/ui/robots/BookmarksRobot.kt b/app/src/androidTest/java/org/mozilla/fenix/ui/robots/BookmarksRobot.kt index 8155427bff..babea9abd0 100644 --- a/app/src/androidTest/java/org/mozilla/fenix/ui/robots/BookmarksRobot.kt +++ b/app/src/androidTest/java/org/mozilla/fenix/ui/robots/BookmarksRobot.kt @@ -32,6 +32,7 @@ import androidx.test.uiautomator.Until import org.hamcrest.Matchers.allOf import org.hamcrest.Matchers.containsString import org.junit.Assert.assertEquals +import org.junit.Assert.assertFalse import org.mozilla.fenix.R import org.mozilla.fenix.helpers.TestAssetHelper import org.mozilla.fenix.helpers.TestAssetHelper.waitingTime @@ -67,6 +68,8 @@ class BookmarksRobot { assertFolderTitle(title) } + fun verifyBookmarkFolderIsNotCreated(title: String) = assertBookmarkFolderIsNotCreated(title) + fun verifyBookmarkTitle(title: String) { mDevice.findObject(UiSelector().text(title)).waitForExists(waitingTime) assertBookmarkTitle(title) @@ -318,6 +321,20 @@ private fun assertCloseButton() = closeButton().check(matches(withEffectiveVisib private fun assertEmptyBookmarksList() = onView(withId(R.id.bookmarks_empty_view)).check(matches(withText("No bookmarks here"))) +private fun assertBookmarkFolderIsNotCreated(title: String) { + mDevice.findObject( + UiSelector() + .resourceId("$packageName:id/bookmarks_wrapper") + ).waitForExists(waitingTime) + + assertFalse( + mDevice.findObject( + UiSelector() + .textContains(title) + ).waitForExists(waitingTime) + ) +} + private fun assertBookmarkFavicon(forUrl: Uri) = bookmarkFavicon(forUrl.toString()).check( matches( withEffectiveVisibility(