diff --git a/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt b/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt index 47f84d6cb8..a9644d3fa7 100644 --- a/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt @@ -905,9 +905,12 @@ class HomeFragment : Fragment() { this.viewLifecycleOwner, context, onItemTapped = { + if (it !is HomeMenu.Item.DesktopMode) { + hideOnboardingIfNeeded() + } + when (it) { HomeMenu.Item.Settings -> { - hideOnboardingIfNeeded() nav( R.id.homeFragment, HomeFragmentDirections.actionGlobalSettingsFragment() @@ -916,14 +919,12 @@ class HomeFragment : Fragment() { } HomeMenu.Item.CustomizeHome -> { context.metrics.track(Event.HomeScreenCustomizedHomeClicked) - hideOnboardingIfNeeded() nav( R.id.homeFragment, HomeFragmentDirections.actionGlobalHomeSettingsFragment() ) } is HomeMenu.Item.SyncAccount -> { - hideOnboardingIfNeeded() val directions = when (it.accountState) { AccountState.AUTHENTICATED -> BrowserFragmentDirections.actionGlobalAccountSettingsFragment() @@ -938,30 +939,24 @@ class HomeFragment : Fragment() { ) } HomeMenu.Item.Bookmarks -> { - hideOnboardingIfNeeded() nav( R.id.homeFragment, HomeFragmentDirections.actionGlobalBookmarkFragment(BookmarkRoot.Mobile.id) ) } HomeMenu.Item.History -> { - hideOnboardingIfNeeded() nav( R.id.homeFragment, HomeFragmentDirections.actionGlobalHistoryFragment() ) } - HomeMenu.Item.Downloads -> { - hideOnboardingIfNeeded() nav( R.id.homeFragment, HomeFragmentDirections.actionGlobalDownloadsFragment() ) } - HomeMenu.Item.Help -> { - hideOnboardingIfNeeded() (activity as HomeActivity).openToBrowserAndLoad( searchTermOrURL = SupportUtils.getSumoURLForTopic(context, HELP), newTab = true, @@ -969,7 +964,6 @@ class HomeFragment : Fragment() { ) } HomeMenu.Item.WhatsNew -> { - hideOnboardingIfNeeded() WhatsNew.userViewedWhatsNew(context) context.metrics.track(Event.WhatsNewTapped) (activity as HomeActivity).openToBrowserAndLoad( @@ -994,7 +988,6 @@ class HomeFragment : Fragment() { ) } HomeMenu.Item.ReconnectSync -> { - hideOnboardingIfNeeded() nav( R.id.homeFragment, HomeFragmentDirections.actionGlobalAccountProblemFragment()