From 78915862d3b1a6de60a08dfb0509cf32cf0db513 Mon Sep 17 00:00:00 2001 From: Emily Kager Date: Tue, 21 May 2019 13:07:24 -0700 Subject: [PATCH] [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/2699 - Removes Feedback from Settings --- .../java/org/mozilla/fenix/settings/SettingsFragment.kt | 8 -------- .../main/java/org/mozilla/fenix/settings/SupportUtils.kt | 1 - app/src/main/res/xml/preferences.xml | 4 ---- 3 files changed, 13 deletions(-) diff --git a/app/src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt b/app/src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt index 5ce9ca2138..3b24eb6a05 100644 --- a/app/src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt @@ -33,7 +33,6 @@ import org.mozilla.fenix.R.string.pref_key_accessibility import org.mozilla.fenix.R.string.pref_key_account import org.mozilla.fenix.R.string.pref_key_account_category import org.mozilla.fenix.R.string.pref_key_data_choices -import org.mozilla.fenix.R.string.pref_key_feedback import org.mozilla.fenix.R.string.pref_key_help import org.mozilla.fenix.R.string.pref_key_language import org.mozilla.fenix.R.string.pref_key_leakcanary @@ -152,13 +151,6 @@ class SettingsFragment : PreferenceFragmentCompat(), CoroutineScope, AccountObse resources.getString(pref_key_rate) -> { startActivity(Intent(Intent.ACTION_VIEW, Uri.parse(SupportUtils.RATE_APP_URL))) } - resources.getString(pref_key_feedback) -> { - (activity as HomeActivity).openToBrowserAndLoad( - searchTermOrURL = SupportUtils.FEEDBACK_URL, - newTab = true, - from = BrowserDirection.FromSettings - ) - } resources.getString(pref_key_about) -> { navigateToAbout() } diff --git a/app/src/main/java/org/mozilla/fenix/settings/SupportUtils.kt b/app/src/main/java/org/mozilla/fenix/settings/SupportUtils.kt index a792f5e038..a847504e1f 100644 --- a/app/src/main/java/org/mozilla/fenix/settings/SupportUtils.kt +++ b/app/src/main/java/org/mozilla/fenix/settings/SupportUtils.kt @@ -15,7 +15,6 @@ import java.net.URLEncoder import java.util.Locale object SupportUtils { - const val FEEDBACK_URL = "https://input.mozilla.org" const val RATE_APP_URL = "market://details?id=" + BuildConfig.APPLICATION_ID const val MOZILLA_MANIFESTO_URL = "https://www.mozilla.org/en-GB/about/manifesto/" val PRIVACY_NOTICE_URL: String diff --git a/app/src/main/res/xml/preferences.xml b/app/src/main/res/xml/preferences.xml index 19a1a4721b..296a27e47a 100644 --- a/app/src/main/res/xml/preferences.xml +++ b/app/src/main/res/xml/preferences.xml @@ -92,10 +92,6 @@ android:icon="@drawable/ic_bookmark_outline" android:key="@string/pref_key_rate" android:title="@string/preferences_rate" /> -