Archives/iceraven-browser
2
0
Fork 0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-15 18:12:54 +00:00
Code Issues Releases Wiki Activity

Close #25982: Fix check between current and new when adding a bookmark

Browse Source
This commit is contained in:
Jonathan Almeida 2022-07-11 12:29:15 -04:00 committed by mergify[bot]
parent 26d22e7528
commit 7309b671b1
2 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/src/main/java/org/mozilla/fenix/components/bookmarks/BookmarksUseCase.kt
View File

@ -30,8 +30,8 @@ class BookmarksUseCase(
*/ */
@WorkerThread @WorkerThread
suspend operator fun invoke(url: String, title: String, position: UInt? = null): Boolean { suspend operator fun invoke(url: String, title: String, position: UInt? = null): Boolean {
try { return try {
val canAdd = storage.getBookmarksWithUrl(url).firstOrNull { it.url == it.url } == null val canAdd = storage.getBookmarksWithUrl(url).firstOrNull { it.url == url } == null
if (canAdd) { if (canAdd) {
storage.addItem( storage.addItem(
@ -41,9 +41,9 @@ class BookmarksUseCase(
position = position position = position
) )
} }
return canAdd canAdd
} catch (e: PlacesException.UrlParseFailed) { } catch (e: PlacesException.UrlParseFailed) {
return false false
} }
} }
} }

4
app/src/test/java/org/mozilla/fenix/components/bookmarks/BookmarksUseCaseTest.kt
View File

@ -44,9 +44,11 @@ class BookmarksUseCaseTest {
fun `WHEN adding bookmark THEN new item is stored`() = runTest { fun `WHEN adding bookmark THEN new item is stored`() = runTest {
val bookmarksStorage = mockk<BookmarksStorage>(relaxed = true) val bookmarksStorage = mockk<BookmarksStorage>(relaxed = true)
val historyStorage = mockk<HistoryStorage>(relaxed = true) val historyStorage = mockk<HistoryStorage>(relaxed = true)
val bookmarkNode = mockk<BookmarkNode>()
val useCase = BookmarksUseCase(bookmarksStorage, historyStorage) val useCase = BookmarksUseCase(bookmarksStorage, historyStorage)
coEvery { bookmarksStorage.getBookmarksWithUrl(any()) }.coAnswers { emptyList() } every { bookmarkNode.url }.answers { "https://firefox.com" }
coEvery { bookmarksStorage.getBookmarksWithUrl(any()) }.coAnswers { listOf(bookmarkNode) }
val result = useCase.addBookmark("https://mozilla.org", "Mozilla") val result = useCase.addBookmark("https://mozilla.org", "Mozilla")