From 720589cbb05598138cfc38b7469da29087ea095c Mon Sep 17 00:00:00 2001 From: Sebastian Kaspari Date: Mon, 26 Aug 2019 17:02:11 +0200 Subject: [PATCH] [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4873: Use manifest placeholder to inject sharedUserId. --- app/build.gradle | 8 ++++++++ app/src/fennecProduction/AndroidManifest.xml | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/app/build.gradle b/app/build.gradle index aeba9bb7f3..ecf141fd31 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -72,6 +72,14 @@ android { fennecProduction releaseTemplate >> { buildConfigField "boolean", "USE_RELEASE_VERSIONING", "true" applicationIdSuffix ".firefox" + manifestPlaceholders = [ + // This release type is meant to replace Firefox (Release channel) and therefore needs to inherit + // its sharedUserId for all eternity. Shipping an app update without sharedUserId can have + // fatal consequences. For example see: + // - https://issuetracker.google.com/issues/36924841 + // - https://issuetracker.google.com/issues/36905922 + "sharedUserId": "org.mozilla.firefox.sharedID" + ] } } diff --git a/app/src/fennecProduction/AndroidManifest.xml b/app/src/fennecProduction/AndroidManifest.xml index aaa42eed76..ad6a746981 100644 --- a/app/src/fennecProduction/AndroidManifest.xml +++ b/app/src/fennecProduction/AndroidManifest.xml @@ -7,6 +7,6 @@ - https://issuetracker.google.com/issues/36905922 --> + android:sharedUserId="${sharedUserId}">