From 6f77ec5951393b676a739b5950935d322fe11749 Mon Sep 17 00:00:00 2001 From: ekager Date: Thu, 16 Apr 2020 19:28:08 -0700 Subject: [PATCH] Use HomeFragment viewLifecycleOwner for BrowserSessionsObserver --- .../org/mozilla/fenix/home/HomeFragment.kt | 21 +++++++++---------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt b/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt index c8fca03ae3..81787c7057 100644 --- a/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt @@ -159,17 +159,6 @@ class HomeFragment : Fragment() { override fun onCreate(savedInstanceState: Bundle?) { super.onCreate(savedInstanceState) postponeEnterTransition() - - val sessionObserver = BrowserSessionsObserver( - sessionManager, - requireComponents.core.store, - singleSessionObserver - ) { - emitSessionChanges() - } - - lifecycle.addObserver(sessionObserver) - if (!onboarding.userHasBeenOnboarded()) { requireComponents.analytics.metrics.track(Event.OpenedAppFirstRun) } @@ -183,6 +172,16 @@ class HomeFragment : Fragment() { val view = inflater.inflate(R.layout.fragment_home, container, false) val activity = activity as HomeActivity + val sessionObserver = BrowserSessionsObserver( + sessionManager, + requireComponents.core.store, + singleSessionObserver + ) { + emitSessionChanges() + } + + viewLifecycleOwner.lifecycle.addObserver(sessionObserver) + currentMode = CurrentMode( view.context, onboarding,