From 6638aeb3e5cb4476cf3c9efa4adea303c9f65c7d Mon Sep 17 00:00:00 2001 From: "oana.horvath" Date: Mon, 21 Aug 2023 12:34:40 +0300 Subject: [PATCH] Bug 1849278 - Replace YouTube link with a scheme URI in tests Remove externalLinkTest --- .../java/org/mozilla/fenix/ui/ComposeSmokeTest.kt | 5 ++--- .../java/org/mozilla/fenix/ui/SmokeTest.kt | 5 ++--- .../java/org/mozilla/fenix/ui/WebControlsTest.kt | 11 ----------- 3 files changed, 4 insertions(+), 17 deletions(-) diff --git a/app/src/androidTest/java/org/mozilla/fenix/ui/ComposeSmokeTest.kt b/app/src/androidTest/java/org/mozilla/fenix/ui/ComposeSmokeTest.kt index 8e0aee94c2..c18249a0c4 100644 --- a/app/src/androidTest/java/org/mozilla/fenix/ui/ComposeSmokeTest.kt +++ b/app/src/androidTest/java/org/mozilla/fenix/ui/ComposeSmokeTest.kt @@ -117,13 +117,12 @@ class ComposeSmokeTest { // Device or AVD requires a Google Services Android OS installation with Play Store installed // Verifies the Open in app button when an app is installed - @Ignore("Failing, see: https://bugzilla.mozilla.org/show_bug.cgi?id=1849278") @Test fun mainMenuOpenInAppTest() { - val youtubeURL = "https://m.youtube.com/user/mozilla?cbrd=1" + val youtubeURL = "vnd.youtube://".toUri() navigationToolbar { - }.enterURLAndEnterToBrowser(youtubeURL.toUri()) { + }.enterURLAndEnterToBrowser(youtubeURL) { verifyNotificationDotOnMainMenu() }.openThreeDotMenu { }.clickOpenInApp { diff --git a/app/src/androidTest/java/org/mozilla/fenix/ui/SmokeTest.kt b/app/src/androidTest/java/org/mozilla/fenix/ui/SmokeTest.kt index 49338e68e4..28b8ba3ec4 100644 --- a/app/src/androidTest/java/org/mozilla/fenix/ui/SmokeTest.kt +++ b/app/src/androidTest/java/org/mozilla/fenix/ui/SmokeTest.kt @@ -116,13 +116,12 @@ class SmokeTest { // Device or AVD requires a Google Services Android OS installation with Play Store installed // Verifies the Open in app button when an app is installed - @Ignore("Failing, see: https://bugzilla.mozilla.org/show_bug.cgi?id=1849278") @Test fun mainMenuOpenInAppTest() { - val youtubeURL = "https://m.youtube.com/user/mozilla?cbrd=1" + val youtubeURL = "vnd.youtube://".toUri() navigationToolbar { - }.enterURLAndEnterToBrowser(youtubeURL.toUri()) { + }.enterURLAndEnterToBrowser(youtubeURL) { verifyNotificationDotOnMainMenu() }.openThreeDotMenu { }.clickOpenInApp { diff --git a/app/src/androidTest/java/org/mozilla/fenix/ui/WebControlsTest.kt b/app/src/androidTest/java/org/mozilla/fenix/ui/WebControlsTest.kt index 480b7cab99..91f05502e7 100644 --- a/app/src/androidTest/java/org/mozilla/fenix/ui/WebControlsTest.kt +++ b/app/src/androidTest/java/org/mozilla/fenix/ui/WebControlsTest.kt @@ -163,17 +163,6 @@ class WebControlsTest { } } - @Test - fun externalLinkTest() { - val externalLinksPage = TestAssetHelper.getExternalLinksAsset(mockWebServer) - - navigationToolbar { - }.enterURLAndEnterToBrowser(externalLinksPage.url) { - clickPageObject(itemContainingText("External link")) - verifyUrl("duckduckgo") - } - } - @Test fun emailLinkTest() { val externalLinksPage = TestAssetHelper.getExternalLinksAsset(mockWebServer)