From 625233f66488412287e3400a08d1c5c55439ff2e Mon Sep 17 00:00:00 2001 From: Jonathan Almeida Date: Wed, 13 Oct 2021 15:42:25 -0400 Subject: [PATCH] Close #21910: Fix intermittent failures in SelectTabUseCaseWrapperTest --- .../tabstray/browser/SelectTabUseCaseWrapperTest.kt | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/app/src/test/java/org/mozilla/fenix/tabstray/browser/SelectTabUseCaseWrapperTest.kt b/app/src/test/java/org/mozilla/fenix/tabstray/browser/SelectTabUseCaseWrapperTest.kt index 7e82c3ac9..cc4d91140 100644 --- a/app/src/test/java/org/mozilla/fenix/tabstray/browser/SelectTabUseCaseWrapperTest.kt +++ b/app/src/test/java/org/mozilla/fenix/tabstray/browser/SelectTabUseCaseWrapperTest.kt @@ -7,6 +7,7 @@ package org.mozilla.fenix.tabstray.browser import io.mockk.mockk import io.mockk.verify import mozilla.components.feature.tabs.TabsUseCases +import org.junit.Assert.assertEquals import org.junit.Test import org.mozilla.fenix.components.metrics.Event import org.mozilla.fenix.components.metrics.MetricController @@ -18,25 +19,27 @@ class SelectTabUseCaseWrapperTest { @Test fun `WHEN invoked with no source name THEN metrics with unknown source, use case and callback are triggered`() { - val onSelect: (String) -> Unit = mockk(relaxed = true) + var invoked = "" + val onSelect: (String) -> Unit = { invoked = it } val wrapper = SelectTabUseCaseWrapper(metricController, selectUseCase, onSelect) wrapper("123") verify { metricController.track(Event.OpenedExistingTab("unknown")) } verify { selectUseCase("123") } - verify { onSelect("123") } + assertEquals("123", invoked) } @Test fun `WHEN invoked with a source name THEN metrics, use case and callback are triggered`() { - val onSelect: (String) -> Unit = mockk(relaxed = true) + var invoked = "" + val onSelect: (String) -> Unit = { invoked = it } val wrapper = SelectTabUseCaseWrapper(metricController, selectUseCase, onSelect) wrapper("123", "Test") verify { metricController.track(Event.OpenedExistingTab("Test")) } verify { selectUseCase("123") } - verify { onSelect("123") } + assertEquals("123", invoked) } }