Archives/iceraven-browser
2
0
Fork 0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-19 09:25:34 +00:00
Code Issues Releases Wiki Activity

[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/16345: Update share icon shape

Browse Source 
updating share icon to a filled shape, like default toolbar menu across all app
This commit is contained in:
LeoMaldonado 2020-11-05 17:46:37 -03:00 committed by ekager
parent c6e4316e75
commit 60820051d1
6 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/src/main/java/org/mozilla/fenix/components/toolbar/DefaultToolbarMenu.kt
View File

@ -125,7 +125,7 @@ class DefaultToolbarMenu(
}
val share = BrowserMenuItemToolbar.Button(
imageResource = R.drawable.ic_hollow_share,
imageResource = R.drawable.ic_share_filled,
contentDescription = context.getString(R.string.browser_menu_share),
iconTintColorResource = primaryTextColor(),
listener = {
@ -133,7 +133,6 @@ class DefaultToolbarMenu(
}
)
registerForIsBookmarkedUpdates()
val bookmark = BrowserMenuItemToolbar.TwoStateButton(
primaryImageResource = R.drawable.ic_bookmark_filled,
primaryContentDescription = context.getString(R.string.browser_menu_edit_bookmark),

2
app/src/main/res/drawable/ic_hollow_share.xml → app/src/main/res/drawable/ic_share_filled.xml
View File

@ -8,5 +8,5 @@
android:viewportWidth="24"
android:viewportHeight="24">
<path android:fillColor="?primaryText"
android:pathData="M17 14a3.99 3.99 0 0 0-2.91 1.27L9.87 13c0.17-0.63 0.17-1.3 0-1.94l4.22-2.3A4 4 0 1 0 13.13 7L8.91 9.27a4 4 0 1 0 0 5.46L13.13 17A4 4 0 1 0 17 14zm0-10a2 2 0 1 1 0 4 2 2 0 0 1 0-4zM6 14a2 2 0 1 1 0-4 2 2 0 0 1 0 4zm11 6a2 2 0 1 1 0-4 2 2 0 0 1 0 4z" />
android:pathData="M18,16.08c-0.76,0 -1.44,0.3 -1.96,0.77L8.91,12.7c0.05,-0.23 0.09,-0.46 0.09,-0.7s-0.04,-0.47 -0.09,-0.7l7.05,-4.11c0.54,0.5 1.25,0.81 2.04,0.81 1.66,0 3,-1.34 3,-3s-1.34,-3 -3,-3 -3,1.34 -3,3c0,0.24 0.04,0.47 0.09,0.7L8.04,9.81C7.5,9.31 6.79,9 6,9c-1.66,0 -3,1.34 -3,3s1.34,3 3,3c0.79,0 1.5,-0.31 2.04,-0.81l7.12,4.16c-0.05,0.21 -0.08,0.43 -0.08,0.65 0,1.61 1.31,2.92 2.92,2.92 1.61,0 2.92,-1.31 2.92,-2.92s-1.31,-2.92 -2.92,-2.92z" />
</vector>

2
app/src/main/res/layout/collection_home_list_row.xml
View File

@ -68,7 +68,7 @@
app:layout_constraintBottom_toBottomOf="@id/collection_icon"
app:layout_constraintEnd_toStartOf="@id/collection_overflow_button"
app:layout_constraintTop_toTopOf="@id/collection_icon"
app:srcCompat="@drawable/ic_hollow_share"
app:srcCompat="@drawable/ic_share_filled"
tools:visibility="visible" />
<ImageButton

2
app/src/main/res/layout/tab_header.xml
View File

@ -27,7 +27,7 @@
android:layout_height="48dp"
android:background="?android:attr/selectableItemBackgroundBorderless"
android:contentDescription="@string/tabs_menu_share_tabs"
app:srcCompat="@drawable/ic_hollow_share"
app:srcCompat="@drawable/ic_share_filled"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toStartOf="@+id/close_tabs_button"
app:layout_constraintTop_toTopOf="parent" />

2
app/src/main/res/menu/bookmarks_select_multi.xml
View File

@ -6,7 +6,7 @@
xmlns:app="http://schemas.android.com/apk/res-auto">
<item
android:id="@+id/share_bookmark_multi_select"
android:icon="@drawable/ic_hollow_share"
android:icon="@drawable/ic_share_filled"
app:iconTint="@color/white_color"
android:title="@string/browser_menu_share"
app:showAsAction="ifRoom" />

2
app/src/main/res/menu/history_select_multi.xml
View File

@ -6,7 +6,7 @@
xmlns:app="http://schemas.android.com/apk/res-auto">
<item
android:id="@+id/share_history_multi_select"
android:icon="@drawable/ic_hollow_share"
android:icon="@drawable/ic_share_filled"
app:iconTint="@color/white_color"
android:title="@string/browser_menu_share"
app:showAsAction="ifRoom" />