mirror of
https://github.com/fork-maintainers/iceraven-browser
synced 2024-11-09 19:10:42 +00:00
For #26528 - Add a nimbus feature flag for MR Home Onboarding Dialog
This commit is contained in:
parent
3434c702de
commit
5f2ebf8125
@ -1208,7 +1208,7 @@ class Settings(private val appContext: Context) : PreferencesHolder {
|
|||||||
)
|
)
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Indicates if sync on-boarding CFR should be shown
|
* Indicates if sync onboarding CFR should be shown.
|
||||||
* Returns true if the [FeatureFlags.showSynCFR] and [R.string.pref_key_should_show_sync_cfr] are true.
|
* Returns true if the [FeatureFlags.showSynCFR] and [R.string.pref_key_should_show_sync_cfr] are true.
|
||||||
*/
|
*/
|
||||||
var showSyncCFR by lazyFeatureFlagPreference(
|
var showSyncCFR by lazyFeatureFlagPreference(
|
||||||
@ -1217,6 +1217,15 @@ class Settings(private val appContext: Context) : PreferencesHolder {
|
|||||||
default = { onboardScreenSection[OnboardingSection.SYNC_CFR] == true },
|
default = { onboardScreenSection[OnboardingSection.SYNC_CFR] == true },
|
||||||
)
|
)
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Indicates if home onboarding dialog should be shown.
|
||||||
|
*/
|
||||||
|
var showHomeOnboardingDialog by lazyFeatureFlagPreference(
|
||||||
|
appContext.getPreferenceKey(R.string.pref_key_should_show_home_onboarding_dialog),
|
||||||
|
featureFlag = FeatureFlags.showHomeOnboarding,
|
||||||
|
default = { onboardScreenSection[OnboardingSection.HOME_ONBOARDING_DIALOG] == true },
|
||||||
|
)
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Indicates if the recent tabs functionality should be visible.
|
* Indicates if the recent tabs functionality should be visible.
|
||||||
* Returns true if the [FeatureFlags.showRecentTabsFeature] and [R.string.pref_key_recent_tabs] are true.
|
* Returns true if the [FeatureFlags.showRecentTabsFeature] and [R.string.pref_key_recent_tabs] are true.
|
||||||
|
@ -235,8 +235,10 @@
|
|||||||
<string name="pref_key_has_inactive_tabs_auto_close_dialog_dismissed" translatable="false">pref_key_has_inactive_tabs_auto_close_dialog_dismissed</string>
|
<string name="pref_key_has_inactive_tabs_auto_close_dialog_dismissed" translatable="false">pref_key_has_inactive_tabs_auto_close_dialog_dismissed</string>
|
||||||
<!-- A value of `true` means the jump back in onboarding popup has not been shown yet -->
|
<!-- A value of `true` means the jump back in onboarding popup has not been shown yet -->
|
||||||
<string name="pref_key_should_show_jump_back_in_tabs_popup" translatable="false">pref_key_should_show_jump_back_in_tabs_popup</string>
|
<string name="pref_key_should_show_jump_back_in_tabs_popup" translatable="false">pref_key_should_show_jump_back_in_tabs_popup</string>
|
||||||
<!-- A value of `true` means the on-boarding sync CFR have not been shown yet -->
|
<!-- A value of `true` means the onboarding sync CFR have not been shown yet -->
|
||||||
<string name="pref_key_should_show_sync_cfr" translatable="false">pref_key_should_show_sync_cfr</string>
|
<string name="pref_key_should_show_sync_cfr" translatable="false">pref_key_should_show_sync_cfr</string>
|
||||||
|
<!-- A value of `true` means the home onboarding dialog have not been shown yet -->
|
||||||
|
<string name="pref_key_should_show_home_onboarding_dialog" translatable="false">pref_key_should_show_home_onboarding_dialog</string>
|
||||||
|
|
||||||
<string name="pref_key_debug_settings" translatable="false">pref_key_debug_settings</string>
|
<string name="pref_key_debug_settings" translatable="false">pref_key_debug_settings</string>
|
||||||
|
|
||||||
|
@ -47,21 +47,24 @@ features:
|
|||||||
default:
|
default:
|
||||||
{
|
{
|
||||||
"sync-cfr": false,
|
"sync-cfr": false,
|
||||||
"wallpapers": false
|
"wallpapers": false,
|
||||||
|
"home-onboarding-dialog": false,
|
||||||
}
|
}
|
||||||
defaults:
|
defaults:
|
||||||
- channel: nightly
|
- channel: nightly
|
||||||
value: {
|
value: {
|
||||||
"sections-enabled": {
|
"sections-enabled": {
|
||||||
"sync-cfr": false,
|
"sync-cfr": false,
|
||||||
"wallpapers": false
|
"wallpapers": false,
|
||||||
|
"home-onboarding-dialog": false,
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
- channel: developer
|
- channel: developer
|
||||||
value: {
|
value: {
|
||||||
"sections-enabled": {
|
"sections-enabled": {
|
||||||
"sync-cfr": false,
|
"sync-cfr": false,
|
||||||
"wallpapers": true
|
"wallpapers": true,
|
||||||
|
"home-onboarding-dialog": false,
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
nimbus-validation:
|
nimbus-validation:
|
||||||
@ -331,3 +334,5 @@ types:
|
|||||||
description: Sync onboarding CFR.
|
description: Sync onboarding CFR.
|
||||||
wallpapers:
|
wallpapers:
|
||||||
description: Wallpapers onboarding dialog.
|
description: Wallpapers onboarding dialog.
|
||||||
|
home-onboarding-dialog:
|
||||||
|
description: Home onboarding dialog for upgraded users.
|
||||||
|
Loading…
Reference in New Issue
Block a user