diff --git a/app/metrics.yaml b/app/metrics.yaml index 2ce397a03..5b57fe956 100644 --- a/app/metrics.yaml +++ b/app/metrics.yaml @@ -2798,6 +2798,19 @@ tabs_tray: notification_emails: - android-probes@mozilla.com expires: "2022-02-01" + inactive_tabs_recently_closed: + type: event + description: | + A user tapped the "Recently closed" option of the inactive tabs menu. + bugs: + - https://github.com/mozilla-mobile/fenix/issues/20328 + data_reviews: + - https://github.com/mozilla-mobile/fenix/issues/20328 + data_sensitivity: + - interaction + notification_emails: + - android-probes@mozilla.com + expires: "2022-08-01" collections: renamed: diff --git a/app/src/main/java/org/mozilla/fenix/components/metrics/Event.kt b/app/src/main/java/org/mozilla/fenix/components/metrics/Event.kt index c204c981f..0e627b7e4 100644 --- a/app/src/main/java/org/mozilla/fenix/components/metrics/Event.kt +++ b/app/src/main/java/org/mozilla/fenix/components/metrics/Event.kt @@ -186,6 +186,7 @@ sealed class Event { object TabsTraySaveToCollectionPressed : Event() object TabsTrayShareAllTabsPressed : Event() object TabsTrayCloseAllTabsPressed : Event() + object TabsTrayRecentlyClosedPressed : Event() object ProgressiveWebAppOpenFromHomescreenTap : Event() object ProgressiveWebAppInstallAsShortcut : Event() diff --git a/app/src/main/java/org/mozilla/fenix/components/metrics/GleanMetricsService.kt b/app/src/main/java/org/mozilla/fenix/components/metrics/GleanMetricsService.kt index def4eb848..1e3fc18b5 100644 --- a/app/src/main/java/org/mozilla/fenix/components/metrics/GleanMetricsService.kt +++ b/app/src/main/java/org/mozilla/fenix/components/metrics/GleanMetricsService.kt @@ -683,6 +683,9 @@ private val Event.wrapper: EventWrapper<*>? is Event.TabsTrayCloseAllTabsPressed -> EventWrapper( { TabsTray.closeAllTabs.record(it) } ) + is Event.TabsTrayRecentlyClosedPressed -> EventWrapper( + { TabsTray.inactiveTabsRecentlyClosed.record(it) } + ) is Event.AutoPlaySettingVisited -> EventWrapper( { Autoplay.visitedSetting.record(it) } ) diff --git a/app/src/main/java/org/mozilla/fenix/tabstray/TabsTrayController.kt b/app/src/main/java/org/mozilla/fenix/tabstray/TabsTrayController.kt index 28ba20c19..f273008c0 100644 --- a/app/src/main/java/org/mozilla/fenix/tabstray/TabsTrayController.kt +++ b/app/src/main/java/org/mozilla/fenix/tabstray/TabsTrayController.kt @@ -174,6 +174,8 @@ class DefaultTabsTrayController( dismissTray() navController.navigate(R.id.recentlyClosedFragment) + + metrics.track(Event.TabsTrayRecentlyClosedPressed) } /** diff --git a/app/src/test/java/org/mozilla/fenix/components/metrics/GleanMetricsServiceTest.kt b/app/src/test/java/org/mozilla/fenix/components/metrics/GleanMetricsServiceTest.kt index 52f8fa8d6..3be006794 100644 --- a/app/src/test/java/org/mozilla/fenix/components/metrics/GleanMetricsServiceTest.kt +++ b/app/src/test/java/org/mozilla/fenix/components/metrics/GleanMetricsServiceTest.kt @@ -249,6 +249,10 @@ class GleanMetricsServiceTest { assertFalse(TabsTray.closeAllTabs.testHasValue()) gleanService.track(Event.TabsTrayCloseAllTabsPressed) assertTrue(TabsTray.closeAllTabs.testHasValue()) + + assertFalse(TabsTray.inactiveTabsRecentlyClosed.testHasValue()) + gleanService.track(Event.TabsTrayRecentlyClosedPressed) + assertTrue(TabsTray.inactiveTabsRecentlyClosed.testHasValue()) } @Test