Archives/iceraven-browser
2
0
Fork 0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-17 15:26:23 +00:00
Code Issues Releases Wiki Activity

[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/9710: Vertically aligns users_count with rating (https://github.com/mozilla-mobile/fenix/pull/9950)

Browse Source
This commit is contained in:
ValentinTimisica 2020-04-15 20:51:55 +03:00 committed by GitHub
parent 6b4334b699
commit 5504208fcd
2 changed files with 46 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

66
app/src/main/res/layout/fragment_add_on_details.xml
View File

@ -126,32 +126,50 @@
android:background="?android:attr/listDivider" android:background="?android:attr/listDivider"
android:importantForAccessibility="no" /> android:importantForAccessibility="no" />
<TextView <androidx.constraintlayout.widget.ConstraintLayout
android:id="@+id/rating_label" android:layout_width="match_parent"
android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_below="@+id/home_page_divider" android:layout_below="@+id/home_page_divider">
style="@style/AboutHeaderContentText"
android:text="@string/mozac_feature_addons_rating" />
<RatingBar <TextView
android:id="@+id/rating_view" android:id="@+id/rating_label"
style="@style/Widget.AppCompat.RatingBar.Small" style="@style/AboutHeaderContentText"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="20dp" android:layout_height="wrap_content"
android:layout_below="@+id/home_page_divider" android:text="@string/mozac_feature_addons_rating"
android:layout_toStartOf="@+id/users_count" app:layout_constraintBottom_toBottomOf="parent"
android:isIndicator="true" app:layout_constraintStart_toStartOf="parent"
android:numStars="5" /> app:layout_constraintTop_toTopOf="parent" />
<RatingBar
android:id="@+id/rating_view"
style="@style/Widget.AppCompat.RatingBar.Small"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginStart="@dimen/addon_details_rating_view_margin_start"
android:layout_marginEnd="@dimen/addon_details_rating_view_margin_end"
android:isIndicator="true"
android:numStars="5"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toStartOf="@+id/users_count"
app:layout_constraintHorizontal_bias="1"
app:layout_constraintHorizontal_chainStyle="packed"
app:layout_constraintStart_toEndOf="@+id/rating_label"
app:layout_constraintTop_toTopOf="parent" />
<TextView
android:id="@+id/users_count"
style="@style/AboutHeaderContentText"
android:layout_width="0dp"
android:layout_height="wrap_content"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toEndOf="@+id/rating_view"
app:layout_constraintTop_toTopOf="parent"
app:layout_constraintWidth_default="wrap"
tools:text="591,642" />
</androidx.constraintlayout.widget.ConstraintLayout>
<TextView
android:id="@+id/users_count"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_below="@+id/home_page_divider"
android:layout_alignParentEnd="true"
android:layout_marginStart="6dp"
style="@style/AboutHeaderContentText"
tools:text="591,642" />
</RelativeLayout> </RelativeLayout>
</ScrollView> </ScrollView>

4
app/src/main/res/values/dimens.xml
View File

@ -134,4 +134,8 @@
<dimen name="onboarding_dual_pane_radio_button_translation_x">-7dp</dimen> <dimen name="onboarding_dual_pane_radio_button_translation_x">-7dp</dimen>
<dimen name="onboarding_dual_pane_radio_button_translation_y">-8dp</dimen> <dimen name="onboarding_dual_pane_radio_button_translation_y">-8dp</dimen>
<!-- Addon Details Fragment -->
<dimen name="addon_details_rating_view_margin_start">6dp</dimen>
<dimen name="addon_details_rating_view_margin_end">6dp</dimen>
</resources> </resources>