Archives/iceraven-browser
2
0
Fork 0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-19 09:25:34 +00:00
Code Issues Releases Wiki Activity

[fenix] For https://github.com/mozilla-mobile/fenix/issues/4339 reduce build warnings (https://github.com/mozilla-mobile/fenix/pull/4340)

Browse Source
This commit is contained in:
Nikit Bhandari 2019-08-01 00:13:49 +05:30 committed by Jeff Boek
parent 853ad4d175
commit 49eb339d15
4 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
app/src/main/java/org/mozilla/fenix/collections/CollectionCreationUIView.kt
View File

@ -43,7 +43,6 @@ class CollectionCreationUIView(
actionEmitter, actionEmitter,
changesObservable changesObservable
) { ) {
override val view = LayoutInflater.from(container.context) override val view = LayoutInflater.from(container.context)
.inflate(R.layout.component_collection_creation, container, true) .inflate(R.layout.component_collection_creation, container, true)

4
app/src/main/java/org/mozilla/fenix/search/toolbar/ToolbarView.kt
View File

@ -14,7 +14,7 @@ import mozilla.components.browser.domains.autocomplete.ShippedDomainsProvider
import mozilla.components.browser.toolbar.BrowserToolbar import mozilla.components.browser.toolbar.BrowserToolbar
import mozilla.components.concept.storage.HistoryStorage import mozilla.components.concept.storage.HistoryStorage
import mozilla.components.feature.toolbar.ToolbarAutocompleteFeature import mozilla.components.feature.toolbar.ToolbarAutocompleteFeature
import mozilla.components.support.ktx.android.content.res.pxToDp import mozilla.components.support.ktx.android.util.dpToPx
import org.mozilla.fenix.R import org.mozilla.fenix.R
import org.mozilla.fenix.ext.getColorFromAttr import org.mozilla.fenix.ext.getColorFromAttr
import org.mozilla.fenix.search.SearchState import org.mozilla.fenix.search.SearchState
@ -66,7 +66,7 @@ class ToolbarView(
view.apply { view.apply {
editMode() editMode()
elevation = resources.pxToDp(TOOLBAR_ELEVATION_IN_DP).toFloat() elevation = TOOLBAR_ELEVATION_IN_DP.dpToPx(resources.displayMetrics).toFloat()
setOnUrlCommitListener { setOnUrlCommitListener {
interactor.onUrlCommitted(it) interactor.onUrlCommitted(it)

3
app/src/main/java/org/mozilla/fenix/settings/TurnOnSyncFragment.kt
View File

@ -66,7 +66,6 @@ class TurnOnSyncFragment : Fragment(), AccountObserver {
// We could auto-close this tab once we get to the end of the authentication process? // We could auto-close this tab once we get to the end of the authentication process?
// Via an interceptor, perhaps. // Via an interceptor, perhaps.
requireComponents.analytics.metrics.track(Event.SyncAuthSignIn) requireComponents.analytics.metrics.track(Event.SyncAuthSignIn)
true
} }
} }
@ -75,8 +74,6 @@ class TurnOnSyncFragment : Fragment(), AccountObserver {
val directions = TurnOnSyncFragmentDirections.actionTurnOnSyncFragmentToPairFragment() val directions = TurnOnSyncFragmentDirections.actionTurnOnSyncFragmentToPairFragment()
Navigation.findNavController(view!!).navigate(directions) Navigation.findNavController(view!!).navigate(directions)
requireComponents.analytics.metrics.track(Event.SyncAuthScanPairing) requireComponents.analytics.metrics.track(Event.SyncAuthScanPairing)
true
} }
} }

2
app/src/main/java/org/mozilla/fenix/settings/quicksettings/QuickSettingsSheetDialogFragment.kt
View File

@ -245,7 +245,7 @@ class QuickSettingsSheetDialogFragment : AppCompatDialogFragment() {
private val sessionObserver = object : Session.Observer { private val sessionObserver = object : Session.Observer {
override fun onUrlChanged(session: Session, url: String) { override fun onUrlChanged(session: Session, url: String) {
lifecycleScope.launch(Dispatchers.IO) { lifecycleScope.launch(Dispatchers.IO) {
val host = session.url.toUri()?.host val host = session.url.toUri().host
val sitePermissions: SitePermissions? = host?.let { val sitePermissions: SitePermissions? = host?.let {
val storage = requireContext().components.core.permissionStorage val storage = requireContext().components.core.permissionStorage
storage.findSitePermissionsBy(it) storage.findSitePermissionsBy(it)