Archives/iceraven-browser
2
0
Fork 0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-11 13:11:01 +00:00
Code Issues Releases Wiki Activity

Merge pull request #3617 from mozilla-mobile/mergify/bp/releases_v118/pr-1576

Browse Source 
Bug 1807127 - Update Sync Device name after refreshing fxa devices (backport #1576)
This commit is contained in:
Pascal Chevrel 2023-09-14 11:38:11 +02:00 committed by GitHub
commit 44fbe57b15
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
app/src/main/java/org/mozilla/fenix/settings/account/AccountSettingsFragment.kt
View File

@ -367,6 +367,7 @@ class AccountSettingsFragment : PreferenceFragmentCompat() {
?.deviceConstellation() ?.deviceConstellation()
?.setDeviceName(newDeviceName, it) ?.setDeviceName(newDeviceName, it)
} }
accountSettingsStore.dispatch(AccountSettingsFragmentAction.UpdateDeviceName(newDeviceName))
} }
return true return true
} }

3
app/src/main/java/org/mozilla/fenix/settings/account/AccountSettingsInteractor.kt
View File

@ -46,7 +46,8 @@ class AccountSettingsInteractor(
} }
// Our "change the device name on the server" operation may fail. // Our "change the device name on the server" operation may fail.
// Currently, we disregard this failure and pretend we succeeded. // Currently, we disregard this failure and pretend we succeeded.
// At the same time, when user changes the device name, we immediately update the UI to display the new name. // At the same time, when user changes the device name,
// we immediately update the UI to display the new name.
// So, in case of a network (or other) failure when talking to the server, // So, in case of a network (or other) failure when talking to the server,
// we'll have a discrepancy - the UI will reflect new value, but actually the value never changed. // we'll have a discrepancy - the UI will reflect new value, but actually the value never changed.
// So, when user presses "sync now", we'll fetch the old value, and reset the UI. // So, when user presses "sync now", we'll fetch the old value, and reset the UI.