From 3ffc6a01f8c207d6dd55dd1ae999f6e096ae1fd8 Mon Sep 17 00:00:00 2001 From: mcarare Date: Wed, 2 Nov 2022 20:04:28 +0200 Subject: [PATCH] [fenix] For https://github.com/mozilla-mobile/fenix/issues/27538: Return null for clipboard text longer than MAX_URI_LENGTH. This avoids extra processing of large text that is unlikely to be an URL. --- .../main/java/org/mozilla/fenix/utils/ClipboardHandler.kt | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/app/src/main/java/org/mozilla/fenix/utils/ClipboardHandler.kt b/app/src/main/java/org/mozilla/fenix/utils/ClipboardHandler.kt index e9c0d1846..17ec1771e 100644 --- a/app/src/main/java/org/mozilla/fenix/utils/ClipboardHandler.kt +++ b/app/src/main/java/org/mozilla/fenix/utils/ClipboardHandler.kt @@ -11,6 +11,7 @@ import android.os.Build import android.view.textclassifier.TextClassifier import androidx.annotation.VisibleForTesting import androidx.core.content.getSystemService +import mozilla.components.support.ktx.kotlin.MAX_URI_LENGTH import mozilla.components.support.utils.SafeUrl import mozilla.components.support.utils.WebURLFinder import org.mozilla.fenix.perf.Performance.logger @@ -58,6 +59,10 @@ class ClipboardHandler(val context: Context) { */ fun extractURL(): String? { return text?.let { + if (it.length > MAX_URI_LENGTH) { + return null + } + val finder = WebURLFinder(it) finder.bestWebURL() }