From 39384786dd30df5536b272749a7c543973b18d6e Mon Sep 17 00:00:00 2001 From: Michael Comella Date: Wed, 11 Nov 2020 15:04:13 -0800 Subject: [PATCH] [fenix] For https://github.com/mozilla-mobile/fenix/issues/16376: move Startup*Test to perf pkg under code owners. Instead of listing many different files here, we should just put them in /perf/ packages and code owner them. --- .github/CODEOWNERS | 1 - .../fenix/{ui => perf}/StartupExcessiveResourceUseTest.kt | 8 ++------ 2 files changed, 2 insertions(+), 7 deletions(-) rename app/src/androidTest/java/org/mozilla/fenix/{ui => perf}/StartupExcessiveResourceUseTest.kt (95%) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index cb8c56ea55..371451c413 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -51,7 +51,6 @@ *StrictMode*kt @mozilla-mobile/Performance *ConstraintLayoutPerfDetector* @mozilla-mobile/Performance *MozillaRunBlockingCheck.kt @mozilla-mobile/Performance -*StartupExcessiveResourceUseTest.kt @mozilla-mobile/Performance # We want to be aware of new features behind flags as well as features # about to be enabled. diff --git a/app/src/androidTest/java/org/mozilla/fenix/ui/StartupExcessiveResourceUseTest.kt b/app/src/androidTest/java/org/mozilla/fenix/perf/StartupExcessiveResourceUseTest.kt similarity index 95% rename from app/src/androidTest/java/org/mozilla/fenix/ui/StartupExcessiveResourceUseTest.kt rename to app/src/androidTest/java/org/mozilla/fenix/perf/StartupExcessiveResourceUseTest.kt index 7449c05777..7df918cb1a 100644 --- a/app/src/androidTest/java/org/mozilla/fenix/ui/StartupExcessiveResourceUseTest.kt +++ b/app/src/androidTest/java/org/mozilla/fenix/perf/StartupExcessiveResourceUseTest.kt @@ -2,7 +2,7 @@ * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ -package org.mozilla.fenix.ui +package org.mozilla.fenix.perf import android.util.Log import android.view.View @@ -16,10 +16,8 @@ import kotlinx.android.synthetic.main.activity_home.* import org.junit.Assert.assertEquals import org.junit.Rule import org.junit.Test -import org.mozilla.fenix.perf.RunBlockingCounter import org.mozilla.fenix.ext.components import org.mozilla.fenix.helpers.HomeActivityTestRule -import org.mozilla.fenix.perf.ComponentInitCount // BEFORE INCREASING THESE VALUES, PLEASE CONSULT WITH THE PERF TEAM. private const val EXPECTED_SUPPRESSION_COUNT = 11 @@ -69,9 +67,7 @@ private val failureMsgRecyclerViewConstraintLayoutChildren = getErrorMessage( * RunBlocking is mostly used to return values to a thread from a coroutine. However, if that * coroutine takes too long, it can lead that thread to block every other operations. * - * The perf team is code owners for this file so they should be notified when the count is modified. - * - * IF YOU UPDATE THE TEST NAME, UPDATE CODE OWNERS. + * The perf team is code owners for this package so they should be notified when the counts are modified. */ class StartupExcessiveResourceUseTest { @get:Rule