Archives/iceraven-browser
2
0
Fork 0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-19 09:25:34 +00:00
Code Issues Releases Wiki Activity

[fenix] For https://github.com/mozilla-mobile/fenix/issues/9256: Attempts to fix installation ping not being sent (https://github.com/mozilla-mobile/fenix/pull/9331)

Browse Source
This commit is contained in:
Sawyer Blatz 2020-03-23 14:27:28 -07:00 committed by GitHub
parent 56ad058b6a
commit 36d9a00925
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/src/main/java/org/mozilla/fenix/components/metrics/AdjustMetricsService.kt
View File

@ -37,6 +37,8 @@ class AdjustMetricsService(private val application: Application) : MetricsServic
true
)
val installationPing = InstallationPing(application)
config.setOnAttributionChangedListener {
if (!it.network.isNullOrEmpty()) {
application.applicationContext.settings().adjustNetwork =
@ -55,7 +57,7 @@ class AdjustMetricsService(private val application: Application) : MetricsServic
it.campaign
}
InstallationPing(application).checkAndSend()
installationPing.checkAndSend()
}
config.setLogLevel(LogLevel.SUPRESS)

7
app/src/main/java/org/mozilla/fenix/components/metrics/InstallationPing.kt
View File

@ -71,14 +71,17 @@ class InstallationPing(private val context: Context) {
}
/**
* Check that required metrics are not empty before attempting to send ping.
* Check that at least one of the metrics values is set before sending the ping.
* Note: it is normal for many of these values to not be set as campaigns do not always
* utilize every attribute!
* */
@VisibleForTesting(otherwise = VisibleForTesting.PRIVATE)
internal fun checkMetricsNotEmpty(): Boolean = listOf(
context.settings().adjustCampaignId,
context.settings().adjustAdGroup,
context.settings().adjustCreative,
context.settings().adjustNetwork
).all { it.isNotEmpty() }
).any { it.isNotEmpty() }
/**
* Trigger sending the `installation` ping if it wasn't sent already.