Bug 1847956 - Show snackBars on top of the toolbar.

fenix/118.0
Arturo Mejia 1 year ago committed by mergify[bot]
parent 279efa5086
commit 36688e9110

@ -79,7 +79,7 @@ class AddonsManagementFragment : Fragment(R.layout.fragment_add_ons_management)
provideAddons = { addons }, provideAddons = { addons },
context = requireContext(), context = requireContext(),
fragmentManager = parentFragmentManager, fragmentManager = parentFragmentManager,
view = view, snackBarParentView = view,
onAddonChanged = { onAddonChanged = {
runIfFragmentIsAttached { runIfFragmentIsAttached {
adapter?.updateAddon(it) adapter?.updateAddon(it)

@ -920,7 +920,7 @@ abstract class BaseBrowserFragment :
provideAddons = ::provideAddons, provideAddons = ::provideAddons,
context = requireContext(), context = requireContext(),
fragmentManager = parentFragmentManager, fragmentManager = parentFragmentManager,
view = view, snackBarParentView = binding.dynamicSnackbarContainer,
), ),
owner = this, owner = this,
view = view, view = view,

@ -36,7 +36,7 @@ class WebExtensionPromptFeature(
private val store: BrowserStore, private val store: BrowserStore,
private val provideAddons: suspend () -> List<Addon>, private val provideAddons: suspend () -> List<Addon>,
private val context: Context, private val context: Context,
private val view: View, private val snackBarParentView: View,
private val fragmentManager: FragmentManager, private val fragmentManager: FragmentManager,
private val onAddonChanged: (Addon) -> Unit = {}, private val onAddonChanged: (Addon) -> Unit = {},
) : LifecycleAwareFeature { ) : LifecycleAwareFeature {
@ -148,7 +148,7 @@ class WebExtensionPromptFeature(
@VisibleForTesting @VisibleForTesting
internal fun showUnsupportedError() { internal fun showUnsupportedError() {
showSnackBar( showSnackBar(
view, snackBarParentView,
context.getString(R.string.addon_not_supported_error), context.getString(R.string.addon_not_supported_error),
FenixSnackbar.LENGTH_LONG, FenixSnackbar.LENGTH_LONG,
) )

@ -39,7 +39,7 @@ class WebExtensionPromptFeatureTest {
store = store, store = store,
provideAddons = { emptyList() }, provideAddons = { emptyList() },
context = testContext, context = testContext,
view = mockk(relaxed = true), snackBarParentView = mockk(relaxed = true),
fragmentManager = mockk(relaxed = true), fragmentManager = mockk(relaxed = true),
), ),
) )

Loading…
Cancel
Save