Archives/iceraven-browser
2
0
Fork 0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-19 09:25:34 +00:00
Code Issues Releases Wiki Activity

[fenix] For https://github.com/mozilla-mobile/fenix/issues/15219 - Fix tab tray handle size.

Browse Source 
Also use dimens for the tab history handle.
This commit is contained in:
person808 2020-09-22 14:36:10 -07:00 committed by ekager
parent 06036292ae
commit 2ddd7950b9
4 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/src/main/java/org/mozilla/fenix/tabtray/TabTrayView.kt
View File

@ -433,14 +433,14 @@ class TabTrayView(
if (multiselect) { if (multiselect) {
R.dimen.tab_tray_multiselect_handle_height R.dimen.tab_tray_multiselect_handle_height
} else { } else {
R.dimen.tab_tray_normal_handle_height R.dimen.bottom_sheet_handle_height
} }
) )
topMargin = view.resources.getDimensionPixelSize( topMargin = view.resources.getDimensionPixelSize(
if (multiselect) { if (multiselect) {
R.dimen.tab_tray_multiselect_handle_top_margin R.dimen.tab_tray_multiselect_handle_top_margin
} else { } else {
R.dimen.tab_tray_normal_handle_top_margin R.dimen.bottom_sheet_handle_top_margin
} }
) )
} }

4
app/src/main/res/layout/component_tabhistory.xml
View File

@ -13,8 +13,8 @@
<View <View
android:id="@+id/handle" android:id="@+id/handle"
android:layout_width="0dp" android:layout_width="0dp"
android:layout_height="3dp" android:layout_height="@dimen/bottom_sheet_handle_height"
android:layout_marginTop="8dp" android:layout_marginTop="@dimen/bottom_sheet_handle_top_margin"
android:background="@color/secondary_text_normal_theme" android:background="@color/secondary_text_normal_theme"
app:layout_constraintEnd_toEndOf="parent" app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent" app:layout_constraintStart_toStartOf="parent"

4
app/src/main/res/layout/component_tabstray.xml
View File

@ -16,8 +16,8 @@
<View <View
android:id="@+id/handle" android:id="@+id/handle"
android:layout_width="0dp" android:layout_width="0dp"
android:layout_height="3dp" android:layout_height="@dimen/bottom_sheet_handle_height"
android:layout_marginTop="8dp" android:layout_marginTop="@dimen/bottom_sheet_handle_top_margin"
android:background="@color/secondary_text_normal_theme" android:background="@color/secondary_text_normal_theme"
app:layout_constraintEnd_toEndOf="parent" app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent" app:layout_constraintStart_toStartOf="parent"

5
app/src/main/res/values/dimens.xml
View File

@ -70,6 +70,9 @@
<!-- Bottom Sheet Fragment card --> <!-- Bottom Sheet Fragment card -->
<dimen name="bottom_sheet_corner_radius">8dp</dimen> <dimen name="bottom_sheet_corner_radius">8dp</dimen>
<dimen name="bottom_sheet_top_padding">8dp</dimen> <dimen name="bottom_sheet_top_padding">8dp</dimen>
<dimen name="bottom_sheet_handle_height">3dp</dimen>
<dimen name="bottom_sheet_handle_top_margin">8dp</dimen>
<!-- Browser Toolbar --> <!-- Browser Toolbar -->
<dimen name="browser_toolbar_height">56dp</dimen> <dimen name="browser_toolbar_height">56dp</dimen>
@ -172,9 +175,7 @@
<dimen name="tab_tray_thumbnail_height">69dp</dimen> <dimen name="tab_tray_thumbnail_height">69dp</dimen>
<dimen name="tab_tray_favicon_border_radius">4dp</dimen> <dimen name="tab_tray_favicon_border_radius">4dp</dimen>
<dimen name="tab_tray_multiselect_handle_height">11dp</dimen> <dimen name="tab_tray_multiselect_handle_height">11dp</dimen>
<dimen name="tab_tray_normal_handle_height">11dp</dimen>
<dimen name="tab_tray_multiselect_handle_top_margin">0dp</dimen> <dimen name="tab_tray_multiselect_handle_top_margin">0dp</dimen>
<dimen name="tab_tray_normal_handle_top_margin">8dp</dimen>
<dimen name="tab_tray_new_collection_padding_start">24dp</dimen> <dimen name="tab_tray_new_collection_padding_start">24dp</dimen>
<dimen name="tab_tray_new_collection_drawable_padding">28dp</dimen> <dimen name="tab_tray_new_collection_drawable_padding">28dp</dimen>