Archives/iceraven-browser
2
0
Fork 0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-19 09:25:34 +00:00
Code Issues Releases Wiki Activity

[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/2560 - Updates Private Browsing explanation string

Browse Source
This commit is contained in:
Emily Kager 2019-07-16 14:10:33 -07:00 committed by Emily Kager
parent fbd7c53f43
commit 2bc8218ab4
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/PrivateBrowsingDescriptionViewHolder.kt
View File

@ -26,7 +26,7 @@ class PrivateBrowsingDescriptionViewHolder(
val resources = view.context.resources
// Format the description text to include a hyperlink
val appName = resources.getString(R.string.app_name)
view.private_session_description.text = resources.getString(R.string.private_browsing_explanation, appName)
view.private_session_description.text = resources.getString(R.string.private_browsing_placeholder, appName)
val descriptionText = String
.format(view.private_session_description.text.toString(), System.getProperty("line.separator"))
val linkStartIndex = descriptionText.indexOf("\n\n") + 2

2
app/src/main/res/layout/private_browsing_description.xml
View File

@ -23,7 +23,7 @@
android:ellipsize="none"
android:gravity="center_vertical"
android:scrollHorizontally="false"
tools:text="@string/private_browsing_explanation"
tools:text="@string/private_browsing_placeholder"
android:textColor="?primaryText"
android:textSize="14sp" />
</LinearLayout>

4
app/src/main/res/values/strings.xml
View File

@ -21,8 +21,8 @@
<string name="private_browsing_title">You’re in a private session</string>
<!-- Explanation for private browsing displayed to users on home view when they first enable private mode
The first parameter is the name of the app defined in app_name (for example: Fenix) -->
<string name="private_browsing_explanation">%1$s clears your search and browsing history when you close your private
session. While this doesn’t make you anonymous to websites or your internet service provider, it makes it
<string name="private_browsing_placeholder">
%1$s clears your search and browsing history when you quit the app or close all private tabs. While this doesn’t make you anonymous to websites or your internet service provider, it makes it
easier to keep what you do online private from anyone else who uses this device.\n\nCommon myths about private
browsing
</string>