From 2a6785067796d1428291aa25ed45d25751f6bb8e Mon Sep 17 00:00:00 2001 From: Christian Sadilek Date: Thu, 29 Jul 2021 20:14:57 -0400 Subject: [PATCH] [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20533: Fix intermittent test failures of ExceptionsListItemViewHolderTest --- .../viewholders/ExceptionsListItemViewHolderTest.kt | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/app/src/test/java/org/mozilla/fenix/exceptions/viewholders/ExceptionsListItemViewHolderTest.kt b/app/src/test/java/org/mozilla/fenix/exceptions/viewholders/ExceptionsListItemViewHolderTest.kt index 2779de9a5..9d32d3cfe 100644 --- a/app/src/test/java/org/mozilla/fenix/exceptions/viewholders/ExceptionsListItemViewHolderTest.kt +++ b/app/src/test/java/org/mozilla/fenix/exceptions/viewholders/ExceptionsListItemViewHolderTest.kt @@ -11,11 +11,11 @@ import io.mockk.every import io.mockk.impl.annotations.MockK import io.mockk.just import io.mockk.mockk -import io.mockk.slot import io.mockk.verify import mozilla.components.browser.icons.BrowserIcons import mozilla.components.browser.icons.IconRequest import mozilla.components.ui.widgets.WidgetSiteItemView +import org.junit.Assert.assertNotNull import org.junit.Before import org.junit.Test import org.mozilla.fenix.exceptions.ExceptionsInteractor @@ -51,13 +51,16 @@ class ExceptionsListItemViewHolderTest { @Test fun `delete button calls interactor`() { - val slot = slot<(View) -> Unit>() + var clickListener: ((View) -> Unit)? = null val exception = Exception() - every { view.setSecondaryButton(any(), any(), capture(slot)) } just Runs + every { view.setSecondaryButton(any(), any(), any()) } answers { + clickListener = thirdArg() + } ExceptionsListItemViewHolder(view, interactor, icons).bind(exception, url = "mozilla.org") every { interactor.onDeleteOne(exception) } just Runs - slot.captured.invoke(mockk()) + assertNotNull(clickListener) + clickListener!!(mockk()) verify { interactor.onDeleteOne(exception) } }