From 24acedf406ed1231aef419550c913786c82686f5 Mon Sep 17 00:00:00 2001 From: mcarare Date: Thu, 28 Apr 2022 15:19:56 +0300 Subject: [PATCH] For #24707: Remove unused metrics parameter. --- .../fenix/settings/creditcards/CreditCardEditorFragment.kt | 1 - .../creditcards/controller/CreditCardEditorController.kt | 2 -- .../creditcards/DefaultCreditCardEditorControllerTest.kt | 3 --- 3 files changed, 6 deletions(-) diff --git a/app/src/main/java/org/mozilla/fenix/settings/creditcards/CreditCardEditorFragment.kt b/app/src/main/java/org/mozilla/fenix/settings/creditcards/CreditCardEditorFragment.kt index b988fd4f3..ac5f597f1 100644 --- a/app/src/main/java/org/mozilla/fenix/settings/creditcards/CreditCardEditorFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/settings/creditcards/CreditCardEditorFragment.kt @@ -63,7 +63,6 @@ class CreditCardEditorFragment : SecureFragment(R.layout.fragment_credit_card_ed storage = storage, lifecycleScope = lifecycleScope, navController = findNavController(), - requireContext().components.analytics.metrics, showDeleteDialog = ::showDeleteDialog ) ) diff --git a/app/src/main/java/org/mozilla/fenix/settings/creditcards/controller/CreditCardEditorController.kt b/app/src/main/java/org/mozilla/fenix/settings/creditcards/controller/CreditCardEditorController.kt index 596c8ce74..789a0c068 100644 --- a/app/src/main/java/org/mozilla/fenix/settings/creditcards/controller/CreditCardEditorController.kt +++ b/app/src/main/java/org/mozilla/fenix/settings/creditcards/controller/CreditCardEditorController.kt @@ -15,7 +15,6 @@ import mozilla.components.concept.storage.UpdatableCreditCardFields import mozilla.components.service.glean.private.NoExtras import mozilla.components.service.sync.autofill.AutofillCreditCardsAddressesStorage import org.mozilla.fenix.GleanMetrics.CreditCards -import org.mozilla.fenix.components.metrics.MetricController import org.mozilla.fenix.settings.creditcards.CreditCardEditorFragment import org.mozilla.fenix.settings.creditcards.interactor.CreditCardEditorInteractor @@ -61,7 +60,6 @@ class DefaultCreditCardEditorController( private val storage: AutofillCreditCardsAddressesStorage, private val lifecycleScope: CoroutineScope, private val navController: NavController, - private val metrics: MetricController, private val ioDispatcher: CoroutineDispatcher = Dispatchers.IO, private val showDeleteDialog: (DialogInterface.OnClickListener) -> Unit ) : CreditCardEditorController { diff --git a/app/src/test/java/org/mozilla/fenix/settings/creditcards/DefaultCreditCardEditorControllerTest.kt b/app/src/test/java/org/mozilla/fenix/settings/creditcards/DefaultCreditCardEditorControllerTest.kt index 7e168097b..11ffb7888 100644 --- a/app/src/test/java/org/mozilla/fenix/settings/creditcards/DefaultCreditCardEditorControllerTest.kt +++ b/app/src/test/java/org/mozilla/fenix/settings/creditcards/DefaultCreditCardEditorControllerTest.kt @@ -29,7 +29,6 @@ import org.junit.Rule import org.junit.Test import org.junit.runner.RunWith import org.mozilla.fenix.GleanMetrics.CreditCards -import org.mozilla.fenix.components.metrics.MetricController import org.mozilla.fenix.helpers.FenixRobolectricTestRunner import org.mozilla.fenix.settings.creditcards.controller.DefaultCreditCardEditorController @@ -41,7 +40,6 @@ class DefaultCreditCardEditorControllerTest { private val storage: AutofillCreditCardsAddressesStorage = mockk(relaxed = true) private val navController: NavController = mockk(relaxed = true) - private val metrics: MetricController = mockk(relaxed = true) private val showDeleteDialog = mockk<(DialogInterface.OnClickListener) -> Unit>() private lateinit var controller: DefaultCreditCardEditorController @@ -65,7 +63,6 @@ class DefaultCreditCardEditorControllerTest { lifecycleScope = testCoroutineScope, navController = navController, ioDispatcher = testDispatcher, - metrics = metrics, showDeleteDialog = showDeleteDialog ) )