diff --git a/.github/ISSUE_TEMPLATE/---performance-issue.md b/.github/ISSUE_TEMPLATE/---performance-issue.md index 5412b99983..11f342660f 100644 --- a/.github/ISSUE_TEMPLATE/---performance-issue.md +++ b/.github/ISSUE_TEMPLATE/---performance-issue.md @@ -2,7 +2,7 @@ name: "⌛ Performance issue" about: Create a performance issue if the app is slow or it uses too much memory, disk space, battery, or network data title: "" -labels: "eng:performance" +labels: "performance" assignees: '' --- diff --git a/app/build.gradle b/app/build.gradle index f88212a5c1..0fe19a8fa3 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -42,6 +42,7 @@ android { testInstrumentationRunnerArguments clearPackageData: 'true' resValue "bool", "IS_DEBUG", "false" buildConfigField "boolean", "USE_RELEASE_VERSIONING", "false" + buildConfigField "String", "GIT_HASH", "\"\"" // see override in release builds for why it's blank. // This should be the "public" base URL of AMO. buildConfigField "String", "AMO_BASE_URL", "\"https://addons.mozilla.org\"" buildConfigField "String", "AMO_COLLECTION_NAME", "\"7dfae8669acc4312a65e8ba5553036\"" @@ -82,6 +83,10 @@ android { proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro' matchingFallbacks = ['release'] // Use on the "release" build type in dependencies (AARs) + // Changing the build config can cause files that depend on BuildConfig.java to recompile + // so we only set the git hash in release builds to avoid possible recompilation in debug builds. + buildConfigField "String", "GIT_HASH", "\"${Config.getGitHash()}\"" + if (gradle.hasProperty("localProperties.autosignReleaseWithDebugKey")) { signingConfig signingConfigs.debug } @@ -227,6 +232,7 @@ android { composeOptions { kotlinCompilerExtensionVersion = Versions.androidx_compose } + } // ------------------------------------------------------------------------------------------------- diff --git a/app/metrics.yaml b/app/metrics.yaml index 39c7d8dfbe..e7a5732b09 100644 --- a/app/metrics.yaml +++ b/app/metrics.yaml @@ -140,11 +140,12 @@ events: - https://github.com/mozilla-mobile/fenix/pull/13958#issuecomment-676857877 - https://github.com/mozilla-mobile/fenix/pull/18143 - https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789 + - https://github.com/mozilla-mobile/fenix/pull/21316#issuecomment-944615938 data_sensitivity: - interaction notification_emails: - android-probes@mozilla.com - expires: "2021-12-01" + expires: "2022-12-01" default_browser_changed: type: event description: | @@ -270,11 +271,12 @@ events: - https://github.com/mozilla-mobile/fenix/pull/13958#issuecomment-676857877 - https://github.com/mozilla-mobile/fenix/pull/18143 - https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789 + - https://github.com/mozilla-mobile/fenix/pull/21316#issuecomment-944615938 data_sensitivity: - interaction notification_emails: - android-probes@mozilla.com - expires: "2021-12-01" + expires: "2022-12-01" opened_link: type: event description: | @@ -300,30 +302,6 @@ events: - android-probes@mozilla.com - erichards@mozilla.com expires: never - tab_counter_menu_action: - type: event - description: - A tab counter menu item was tapped - extra_keys: - item: - description: | - A string containing the name of the item the user tapped. These items - are: - - New tab, New private tab, Close tab - bugs: - - https://github.com/mozilla-mobile/fenix/issues/11442 - - https://github.com/mozilla-mobile/fenix/issues/19923 - data_reviews: - - https://github.com/mozilla-mobile/fenix/pull/11533 - - https://github.com/mozilla-mobile/fenix/pull/13958#issuecomment-676857877 - - https://github.com/mozilla-mobile/fenix/pull/18143 - - https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789 - data_sensitivity: - - interaction - notification_emails: - - android-probes@mozilla.com - expires: "2021-12-01" synced_tab_opened: type: event description: | @@ -387,11 +365,12 @@ events: data_reviews: - https://github.com/mozilla-mobile/fenix/pull/19936 - https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789 + - https://github.com/mozilla-mobile/fenix/pull/21316#issuecomment-944615938 data_sensitivity: - interaction notification_emails: - android-probes@mozilla.com - expires: "2021-12-10" + expires: "2022-12-10" tab_view_changed: type: event description: | @@ -620,47 +599,6 @@ toolbar_settings: - android-probes@mozilla.com expires: "2022-02-01" -crash_reporter: - opened: - type: event - description: | - The crash reporter was displayed - bugs: - - https://github.com/mozilla-mobile/fenix/issues/1040 - - https://github.com/mozilla-mobile/fenix/issues/19923 - data_reviews: - - https://github.com/mozilla-mobile/fenix/pull/1214#issue-264756708 - - https://github.com/mozilla-mobile/fenix/pull/13958#issuecomment-676857877 - - https://github.com/mozilla-mobile/fenix/pull/18143 - - https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789 - data_sensitivity: - - interaction - notification_emails: - - android-probes@mozilla.com - expires: "2021-12-01" - closed: - type: event - description: | - The crash reporter was closed - extra_keys: - crash_submitted: - description: | - A boolean that tells us whether or not the user submitted a crash - report - bugs: - - https://github.com/mozilla-mobile/fenix/issues/1040 - - https://github.com/mozilla-mobile/fenix/issues/19923 - data_reviews: - - https://github.com/mozilla-mobile/fenix/pull/1214#issue-264756708 - - https://github.com/mozilla-mobile/fenix/pull/13958#issuecomment-676857877 - - https://github.com/mozilla-mobile/fenix/pull/18143 - - https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789 - data_sensitivity: - - interaction - notification_emails: - - android-probes@mozilla.com - expires: "2021-12-01" - context_menu: item_tapped: type: event @@ -1320,6 +1258,7 @@ metrics: lifetime: application description: | How many inactive tabs does the user have. + Value will be 0 if the feature is disabled. send_in_pings: - metrics bugs: @@ -2160,11 +2099,12 @@ custom_tab: - https://github.com/mozilla-mobile/fenix/pull/13958#issuecomment-676857877 - https://github.com/mozilla-mobile/fenix/pull/18143 - https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789 + - https://github.com/mozilla-mobile/fenix/pull/21316#issuecomment-944615938 data_sensitivity: - interaction notification_emails: - android-probes@mozilla.com - expires: "2021-12-01" + expires: "2022-06-01" action_button: type: event description: | @@ -2177,11 +2117,12 @@ custom_tab: - https://github.com/mozilla-mobile/fenix/pull/13958#issuecomment-676857877 - https://github.com/mozilla-mobile/fenix/pull/18143 - https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789 + - https://github.com/mozilla-mobile/fenix/pull/21316#issuecomment-944615938 data_sensitivity: - interaction notification_emails: - android-probes@mozilla.com - expires: "2021-12-01" + expires: "2022-06-01" menu: type: event description: | @@ -2194,11 +2135,12 @@ custom_tab: - https://github.com/mozilla-mobile/fenix/pull/13958#issuecomment-676857877 - https://github.com/mozilla-mobile/fenix/pull/18143 - https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789 + - https://github.com/mozilla-mobile/fenix/pull/21316#issuecomment-944615938 data_sensitivity: - interaction notification_emails: - android-probes@mozilla.com - expires: "2021-12-01" + expires: "2022-06-01" activation: identifier: @@ -2267,11 +2209,12 @@ error_page: - https://github.com/mozilla-mobile/fenix/pull/13958#issuecomment-676857877 - https://github.com/mozilla-mobile/fenix/pull/18143 - https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789 + - https://github.com/mozilla-mobile/fenix/pull/21316#issuecomment-944615938 data_sensitivity: - interaction notification_emails: - android-probes@mozilla.com - expires: "2021-12-01" + expires: "2022-12-01" sync_auth: opened: @@ -2697,7 +2640,19 @@ history: notification_emails: - android-probes@mozilla.com expires: "2022-11-01" - + search_term_group_tapped: + type: event + description: | + A user tapped on a search term group in history + bugs: + - https://github.com/mozilla-mobile/fenix/issues/22299 + data_reviews: + - https://github.com/mozilla-mobile/fenix/pull/22300 + data_sensitivity: + - interaction + notification_emails: + - android-probes@mozilla.com + expires: "2022-11-01" reader_mode: available: @@ -4106,11 +4061,12 @@ app_theme: - https://github.com/mozilla-mobile/fenix/pull/13958#issuecomment-676857877 - https://github.com/mozilla-mobile/fenix/pull/18143 - https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789 + - https://github.com/mozilla-mobile/fenix/pull/21316#issuecomment-944615938 data_sensitivity: - interaction notification_emails: - android-probes@mozilla.com - expires: "2021-12-01" + expires: "2022-12-01" pocket: pocket_top_site_clicked: @@ -4421,11 +4377,12 @@ addons: - https://github.com/mozilla-mobile/fenix/pull/13958#issuecomment-676857877 - https://github.com/mozilla-mobile/fenix/pull/18143 - https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789 + - https://github.com/mozilla-mobile/fenix/pull/21316#issuecomment-944615938 data_sensitivity: - interaction notification_emails: - android-probes@mozilla.com - expires: "2021-12-01" + expires: "2022-08-01" open_addon_in_toolbar_menu: type: event description: | @@ -4442,11 +4399,12 @@ addons: - https://github.com/mozilla-mobile/fenix/pull/13958#issuecomment-676857877 - https://github.com/mozilla-mobile/fenix/pull/18143 - https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789 + - https://github.com/mozilla-mobile/fenix/pull/21316#issuecomment-944615938 data_sensitivity: - interaction notification_emails: - android-probes@mozilla.com - expires: "2021-12-01" + expires: "2022-08-01" open_addon_setting: type: event description: | @@ -4542,11 +4500,12 @@ addons: - https://github.com/mozilla-mobile/fenix/pull/13958#issuecomment-676857877 - https://github.com/mozilla-mobile/fenix/pull/18143 - https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789 + - https://github.com/mozilla-mobile/fenix/pull/21316#issuecomment-944615938 data_sensitivity: - interaction notification_emails: - android-probes@mozilla.com - expires: "2021-12-01" + expires: "2022-08-01" perf.startup: cold_main_app_to_first_frame: diff --git a/app/src/androidTest/assets/pages/download.html b/app/src/androidTest/assets/pages/download.html index 440a3b0c07..e8928cfe30 100644 --- a/app/src/androidTest/assets/pages/download.html +++ b/app/src/androidTest/assets/pages/download.html @@ -1,6 +1,6 @@ - Page content: Globe.svg + Page content: tAJwqaWjJsXS8AhzSninBMCfIZbHBGgcc001lx5DIdDwIcfEgQ6vE5Gb5VgAled17DFZ2A7ZDOHA0NpQPHXXFHPSD4wzCkRWiaOorNI574zLtv4Hjiz6O6T7onmUTGgUQ2YQoiQFyrCrPv8ZB9Kvmt.svg