From 17c7edb7ede672280f7fc8251d58d47a304be499 Mon Sep 17 00:00:00 2001 From: Gabriel Luong Date: Sat, 8 Jan 2022 17:20:05 -0500 Subject: [PATCH] [fenix] For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_delete with @drawable/mozac_ic_delete --- .../home/sessioncontrol/SwipeToDeleteCallback.kt | 2 +- .../viewholders/DownloadsListItemViewHolder.kt | 2 +- .../fenix/tabstray/browser/TabsTouchHelper.kt | 2 +- app/src/main/res/drawable/ic_delete.xml | 16 ---------------- app/src/main/res/layout/inactive_header_item.xml | 2 +- app/src/main/res/menu/bookmarks_edit.xml | 2 +- app/src/main/res/menu/credit_card_editor.xml | 2 +- app/src/main/res/menu/history_menu.xml | 2 +- app/src/main/res/menu/login_options_menu.xml | 2 +- 9 files changed, 8 insertions(+), 24 deletions(-) delete mode 100644 app/src/main/res/drawable/ic_delete.xml diff --git a/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SwipeToDeleteCallback.kt b/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SwipeToDeleteCallback.kt index 862e319841..bbb0f13a92 100644 --- a/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SwipeToDeleteCallback.kt +++ b/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SwipeToDeleteCallback.kt @@ -44,7 +44,7 @@ class SwipeToDeleteCallback( isCurrentlyActive: Boolean ) { super.onChildDraw(c, recyclerView, viewHolder, dX, dY, actionState, isCurrentlyActive) - val icon = AppCompatResources.getDrawable(recyclerView.context, R.drawable.ic_delete) + val icon = AppCompatResources.getDrawable(recyclerView.context, R.drawable.mozac_ic_delete) icon?.setTint(recyclerView.context.getColorFromAttr(R.attr.destructive)) val backgroundDrawable = when { diff --git a/app/src/main/java/org/mozilla/fenix/library/downloads/viewholders/DownloadsListItemViewHolder.kt b/app/src/main/java/org/mozilla/fenix/library/downloads/viewholders/DownloadsListItemViewHolder.kt index eb272e05d0..cf23a13b32 100644 --- a/app/src/main/java/org/mozilla/fenix/library/downloads/viewholders/DownloadsListItemViewHolder.kt +++ b/app/src/main/java/org/mozilla/fenix/library/downloads/viewholders/DownloadsListItemViewHolder.kt @@ -48,7 +48,7 @@ class DownloadsListItemViewHolder( librarySiteItemBinding.favicon.setImageResource(item.getIcon()) - librarySiteItemBinding.overflowMenu.setImageResource(R.drawable.ic_delete) + librarySiteItemBinding.overflowMenu.setImageResource(R.drawable.mozac_ic_delete) librarySiteItemBinding.overflowMenu.showAndEnable() diff --git a/app/src/main/java/org/mozilla/fenix/tabstray/browser/TabsTouchHelper.kt b/app/src/main/java/org/mozilla/fenix/tabstray/browser/TabsTouchHelper.kt index be67b9a990..c036a08fea 100644 --- a/app/src/main/java/org/mozilla/fenix/tabstray/browser/TabsTouchHelper.kt +++ b/app/src/main/java/org/mozilla/fenix/tabstray/browser/TabsTouchHelper.kt @@ -84,7 +84,7 @@ class TouchCallback( } val icon = recyclerView.context.getDrawableWithTint( - R.drawable.ic_delete, + R.drawable.mozac_ic_delete, recyclerView.context.getColorFromAttr(R.attr.destructive) )!! val background = AppCompatResources.getDrawable( diff --git a/app/src/main/res/drawable/ic_delete.xml b/app/src/main/res/drawable/ic_delete.xml deleted file mode 100644 index 016f2ad0b9..0000000000 --- a/app/src/main/res/drawable/ic_delete.xml +++ /dev/null @@ -1,16 +0,0 @@ - - - - - - diff --git a/app/src/main/res/layout/inactive_header_item.xml b/app/src/main/res/layout/inactive_header_item.xml index 6ace4d6a6b..8f872d3323 100644 --- a/app/src/main/res/layout/inactive_header_item.xml +++ b/app/src/main/res/layout/inactive_header_item.xml @@ -64,7 +64,7 @@ app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintTop_toTopOf="parent" - app:srcCompat="@drawable/ic_delete" /> + app:srcCompat="@drawable/mozac_ic_delete" /> \ No newline at end of file diff --git a/app/src/main/res/menu/bookmarks_edit.xml b/app/src/main/res/menu/bookmarks_edit.xml index f9a024b3d6..4aa4bd5af7 100644 --- a/app/src/main/res/menu/bookmarks_edit.xml +++ b/app/src/main/res/menu/bookmarks_edit.xml @@ -6,7 +6,7 @@ xmlns:app="http://schemas.android.com/apk/res-auto"> diff --git a/app/src/main/res/menu/login_options_menu.xml b/app/src/main/res/menu/login_options_menu.xml index 840c9f50d0..276211c3f4 100644 --- a/app/src/main/res/menu/login_options_menu.xml +++ b/app/src/main/res/menu/login_options_menu.xml @@ -25,7 +25,7 @@