From 177013bdfca0794c13b515f621ff8b3f1a75f2d2 Mon Sep 17 00:00:00 2001 From: DreVla Date: Mon, 27 Feb 2023 11:19:15 +0200 Subject: [PATCH] Bug 1817611 - Revert using live region for talkback on navbar swipe A previous PR introduced accessibilityLiveRegion for EngineView in order for talkback to dictate when swiping to another tab on navbar. This change lead to talkback dictating the title/url of the current page even when tapping empty spaces or when certain elements lose focus. Changing the implementation from using live regions to the announceForAccessibility method seems to fix this issue. --- .../main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt | 3 +-- app/src/main/res/layout/fragment_browser.xml | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt b/app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt index 89062bcb37..729f00a44c 100644 --- a/app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt @@ -1136,8 +1136,6 @@ abstract class BaseBrowserFragment : updateThemeForSession(selectedTab) } - binding.engineView.asView().contentDescription = selectedTab.toDisplayTitle() - if (browserInitialized) { view?.let { fullScreenChanged(false) @@ -1146,6 +1144,7 @@ abstract class BaseBrowserFragment : val toolbarHeight = resources.getDimensionPixelSize(R.dimen.browser_toolbar_height) val context = requireContext() resumeDownloadDialogState(selectedTab.id, context.components.core.store, context, toolbarHeight) + it.announceForAccessibility(selectedTab.toDisplayTitle()) } } else { view?.let { view -> initializeUI(view) } diff --git a/app/src/main/res/layout/fragment_browser.xml b/app/src/main/res/layout/fragment_browser.xml index a2d58244f3..a37f8d5a9f 100644 --- a/app/src/main/res/layout/fragment_browser.xml +++ b/app/src/main/res/layout/fragment_browser.xml @@ -32,7 +32,6 @@ android:id="@+id/engineView" android:layout_width="match_parent" android:layout_height="match_parent" - android:accessibilityLiveRegion="polite" android:visibility="gone" />