From 11acd9849c387d9c508dbe1544f1b39dac8a05c8 Mon Sep 17 00:00:00 2001 From: Mugurell Date: Fri, 18 Oct 2019 08:11:56 +0300 Subject: [PATCH] [fenix] Fix https://github.com/mozilla-mobile/fenix/issues/3122 - Hide the "Bookmark saved" Snackbar when user closes BrowserFragment Previously the Snackbar was being inflated in the parent of this Fragment so surviving it being closed. Tying the Snackbar with the Fragment from which it is shown ensures it will be effectively hidden whenever the user navigates from the Fragment. --- .../main/java/org/mozilla/fenix/browser/BrowserFragment.kt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt b/app/src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt index 94951dc4b2..7b69d6794d 100644 --- a/app/src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt @@ -295,8 +295,8 @@ class BrowserFragment : BaseBrowserFragment(), BackHandler { ) requireComponents.analytics.metrics.track(Event.AddBookmark) - view?.let { - FenixSnackbar.make(it.rootView, Snackbar.LENGTH_LONG) + view?.let { view -> + FenixSnackbar.make(view, Snackbar.LENGTH_LONG) .setAnchorView(browserToolbarView.view) .setAction(getString(R.string.edit_bookmark_snackbar_action)) { nav(