From 0ecb2893f053857afc45fe6a4b20acafe4fddb87 Mon Sep 17 00:00:00 2001 From: mcarare Date: Fri, 24 Apr 2020 09:26:06 +0300 Subject: [PATCH] [fenix] For https://github.com/mozilla-mobile/fenix/issues/9913, For https://github.com/mozilla-mobile/fenix/issues/9914: Remove button when disabling it. Setting visibility to GONE allows clicks to parent view in that space. --- .../home/sessioncontrol/viewholders/CollectionViewHolder.kt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/CollectionViewHolder.kt b/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/CollectionViewHolder.kt index ffb3fa354a..752f9e5305 100644 --- a/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/CollectionViewHolder.kt +++ b/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/CollectionViewHolder.kt @@ -17,8 +17,8 @@ import mozilla.components.browser.menu.item.SimpleBrowserMenuItem import mozilla.components.feature.tab.collections.TabCollection import org.mozilla.fenix.R import org.mozilla.fenix.ext.getIconColor -import org.mozilla.fenix.ext.hideAndDisable import org.mozilla.fenix.ext.increaseTapArea +import org.mozilla.fenix.ext.removeAndDisable import org.mozilla.fenix.ext.showAndEnable import org.mozilla.fenix.home.sessioncontrol.CollectionInteractor import org.mozilla.fenix.theme.ThemeManager @@ -83,8 +83,8 @@ class CollectionViewHolder( view.collection_share_button.showAndEnable() view.collection_overflow_button.showAndEnable() } else { - view.collection_share_button.hideAndDisable() - view.collection_overflow_button.hideAndDisable() + view.collection_share_button.removeAndDisable() + view.collection_overflow_button.removeAndDisable() } view.collection_icon.colorFilter = createBlendModeColorFilterCompat(