Archives/iceraven-browser
2
0
Fork 0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-15 18:12:54 +00:00
Code Issues Releases Wiki Activity

[fenix] For https://github.com/mozilla-mobile/fenix/issues/1158 - Use a dot instead of an underscore to seperate values

Browse Source
This commit is contained in:
Jeff Boek 2019-05-31 16:17:49 -07:00
parent b095f86cbf
commit 0d227b360f
2 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
app/metrics.yaml
View File

@ -57,10 +57,10 @@ events:
source: source:
description: > description: >
A string that tells us how the user performed the search. Possible values are: A string that tells us how the user performed the search. Possible values are:
* default_action * default.action
* default_suggestion * default.suggestion
* shortcut_action * shortcut.action
* shortcut_suggestion * shortcut.suggestion
bugs: bugs:
- 959 - 959
@ -327,7 +327,7 @@ metrics:
search_count: search_count:
type: labeled_counter type: labeled_counter
description: > description: >
The labels for this counter are `<search-engine-name>_<source>`. The labels for this counter are `<search-engine-name>.<source>`.
If the search engine is bundled with Fenix `search-engine-name` will be the name of the search engine. If it's a If the search engine is bundled with Fenix `search-engine-name` will be the name of the search engine. If it's a
custom search engine (defined: https://github.com/mozilla-mobile/fenix/issues/1607) the value will be `custom`. custom search engine (defined: https://github.com/mozilla-mobile/fenix/issues/1607) the value will be `custom`.

5
app/src/main/java/org/mozilla/fenix/components/metrics/Metrics.kt
View File

@ -14,6 +14,7 @@ import mozilla.components.support.base.log.logger.Logger
import org.mozilla.fenix.BuildConfig import org.mozilla.fenix.BuildConfig
import org.mozilla.fenix.R import org.mozilla.fenix.R
import java.lang.IllegalArgumentException import java.lang.IllegalArgumentException
import java.util.Locale
sealed class Event { sealed class Event {
@ -171,10 +172,10 @@ sealed class Event {
} }
val countLabel: String val countLabel: String
get() = "${source.searchEngine.name.toLowerCase()}_$label" get() = "${source.searchEngine.name.toLowerCase(Locale.ROOT)}.$label"
val sourceLabel: String val sourceLabel: String
get() = "${source.descriptor}_$label" get() = "${source.descriptor}.$label"
} }
override val extras: Map<String, String>? override val extras: Map<String, String>?